You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 10, 2024. It is now read-only.
when the page takes a while to load, cosmetic filtering does not work as expected. This is caused by a flaw with how we poll new selectors after the initial page selector query. The query is fine, but we fail to add selectors for the added nodes (we only add selectors for sub-nodes). In addition there was a flaw with arguments passed to a method when we switch to polling mode when a new element is added. These two problems conspired to cause ads to appear intermittently.
Steps to Reproduce
Enable slow internet connection (You can use network link conditioner for this)
Description:
when the page takes a while to load, cosmetic filtering does not work as expected. This is caused by a flaw with how we poll new selectors after the initial page selector query. The query is fine, but we fail to add selectors for the added nodes (we only add selectors for sub-nodes). In addition there was a flaw with arguments passed to a method when we switch to polling mode when a new element is added. These two problems conspired to cause ads to appear intermittently.
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily
Brave Version:
1.51.2
Additional Information
Caused by 2 problems on the cosmetic filtering script
The text was updated successfully, but these errors were encountered: