Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add support for multi-window #7574

Closed
Brandon-T opened this issue Jun 6, 2023 · 1 comment · Fixed by #7575
Closed

Add support for multi-window #7574

Brandon-T opened this issue Jun 6, 2023 · 1 comment · Fixed by #7575

Comments

@Brandon-T
Copy link
Collaborator

Problem Description

  • Add support for Multi-Window on iPad

Feature Overview

  • The browser should be able to have multiple windows side by side. For example, Safari allows it.
  • You should have private and regular modes side by side if the user wishes.
  • Should have a button to open multiple windows.
  • Optionally should allow dragging a tab from one window to another.
  • Optionally should allow merging one window with another.
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 28, 2023

Verified on iPad (7th Gen) running iPadOS 16.5.1 using version 1.57 (23.8.28.18)

Settings Menu (Private Tabs)
  • Ensured that Private Tabs menu is shown for normal and private tabs but not in PBM.
Example Example
IMG_1155 IMG_1161
Actions / Context Menu
  • Ensured that Open in New Private Window & Open in New Window appear in the context menu.
  • Ensured that tab is opened in the appropriate window/mode when using the Open in New Private Window & Open in New Window.
  • Ensured that new actions show up in context menu in private and normal tabs.
Example Example Example Example Example
IMG_1146 IMG_1147 IMG_1148 IMG_1134 IMG_1150
Menus / Icons / Onboarding in Windowed Mode
  • Ensured Playlist, Brave Wallet, and Reader Mode icons are displayed in windowed mode.
  • Ensured User is able to interact with icons in windowed mode.
  • Ensured that onboarding pop-ups are shown while in split view.
Example Example Example Example
IMG_1165 IMG_1166 IMG_1167 IMG_1168

Encountered:
#7976
#7978

Screen Modes
  • Ensured that user is able to the different Screen Modes while having multiple windows open.
Example Example
IMG_1142 IMG_1149
Windows View
  • Ensured user is able to view all instances of brave when opening app or when using Show All Windows from the home screen context menu
  • Ensured closing windows by swiping
Example Example Example Example
IMG_1164 IMG_1140 IMG_1154 IMG_1163
Existing Profile
  • Ensured opening private tabs and private tab windows works on existing profile.
  • Ensured entering split view modes works.
  • Ensured opening new window for normal tabs works from the context menus.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.