Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Enable Brave Talk x Jitsi SDK integration on release builds #7560

Closed
kylehickinson opened this issue Jun 2, 2023 · 1 comment · Fixed by #7561
Closed

Enable Brave Talk x Jitsi SDK integration on release builds #7560

kylehickinson opened this issue Jun 2, 2023 · 1 comment · Fixed by #7561
Assignees
@kylehickinson
Labels
enhancement Epic: Brave Talk QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@kylehickinson
Copy link
Collaborator

Description:

Security issue closed last week: https://github.com/brave/security/issues/894

So this can now be enabled on Release builds
@kylehickinson kylehickinson self-assigned this Jun 2, 2023
kylehickinson added a commit that referenced this issue Jun 2, 2023
@kylehickinson
Fix #7560: Add native Brave Talk jitsi integration to release builds
c2100d0
@kylehickinson kylehickinson mentioned this issue Jun 2, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Jun 2, 2023
@kylehickinson
Fix #7560: Add native Brave Talk jitsi integration to release builds
97cb790
@kylehickinson kylehickinson added this to the 1.53 milestone Jun 2, 2023
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 using version 1.56 (23.7.25.16)

Test Plan: #7561 (comment)

  • Verified Native Brave Talk is enabled on release builds
  • Verified user is able to join the brave talk meeting
Example Example Example Example
IMG_3375 IMG_3376 IMG_3377 IMG_3378

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7560: Add native Brave Talk jitsi integration to …
4eba9a5 
…release builds (brave/brave-ios#7561)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Brave Talk QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7560: Add native Brave Talk jitsi integration to release builds brave/brave-ios
2 participants
@kylehickinson @Uni-verse