Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

CarPlay Bugs #7541

Closed
Brandon-T opened this issue May 30, 2023 · 0 comments · Fixed by #7542
Closed

CarPlay Bugs #7541

Brandon-T opened this issue May 30, 2023 · 0 comments · Fixed by #7542
Assignees
@Brandon-T
Labels
bug QA/No release-notes/include
Milestone
1.52

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • CarPlay Next and Previous buttons not working on iOS 16+
  • CarPlay can sometimes crash when initializing off main-thread.
  • CarPlay Now Playing has changed and can not be pushed if already on the navigation stack

Steps to Reproduce

  1. Add multiple items to Playlist
  2. Play the first one
  3. Try to go to the second one

Actual result:

  • Does not go to the second, instead it restarts the first
  • Now Playing not showing properly in the car

Expected result:

  • Should go to the next song (not skip 15s or start over)

Reproduces how often: [Easily reproduced, Intermittent Issue]

  • Intermittent Issue

Brave Version:

  • 1.50.x

Device details:

  • iPhone iOS 16+
@Brandon-T Brandon-T added this to the 1.52 milestone May 30, 2023
@Brandon-T Brandon-T self-assigned this May 30, 2023
@Brandon-T Brandon-T mentioned this issue May 30, 2023
Merged
11 tasks
iccub pushed a commit that referenced this issue Jun 1, 2023
@Brandon-T
Fix #7541: Fixing CarPlay Next and Previous steering wheel buttons (#…
8fef968 
…7542)

Fixing Next and Previous steering wheel buttons.
Fixing Playback with AsyncAwait issues.
Fixing NowPlaying
Fix last played in CarPlay
Fix previous and next buttons not working properly
Fix playing indicator not updating properly
Fix playing previous and next UI updating so it doesn't pop back and forth.
Made code more efficient when updating the UI instead of generating a whole new UI all over again and reconfiguring it.
Fix view view not updating the title bar when the car changes the item playing.
Fix navigation between phone and car to sync only when the folder changes and the item being played changes.
@Uni-verse Uni-verse mentioned this issue Aug 18, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@Brandon-T
Fix brave/brave-ios#7541: Fixing CarPlay Next and Previous steering w…
d31e645 
…heel buttons (brave/brave-ios#7542)

Fixing Next and Previous steering wheel buttons.
Fixing Playback with AsyncAwait issues.
Fixing NowPlaying
Fix last played in CarPlay
Fix previous and next buttons not working properly
Fix playing indicator not updating properly
Fix playing previous and next UI updating so it doesn't pop back and forth.
Made code more efficient when updating the UI instead of generating a whole new UI all over again and reconfiguring it.
Fix view view not updating the title bar when the car changes the item playing.
Fix navigation between phone and car to sync only when the folder changes and the item being played changes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug QA/No release-notes/include
Projects
None yet
Milestone
1.52
Development

Successfully merging a pull request may close this issue.

Fix #7541: Fixing CarPlay Next and Previous steering wheel buttons brave/brave-ios
3 participants
@Brandon-T @iccub @Uni-verse