Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add network level standard mode #7539

Closed
cuba opened this issue May 30, 2023 · 1 comment · Fixed by #7540
Closed

Add network level standard mode #7539

cuba opened this issue May 30, 2023 · 1 comment · Fixed by #7540
Assignees
@cuba
Labels
QA Pass - iPad QA/Yes release-notes/include
Milestone
1.57

Comments

@cuba
Copy link
Contributor

cuba commented May 30, 2023 •
edited
Loading

Description:

We are only handling aggressive/standard for cosmetic filtering. This is a gap in the functionality. We need to update the code to also handle network level standard blocking

Test plan

  1. Test content blockers here: https://test-pages.privacytests.org/tracking_content.html
  2. Ensure blocked count is 19 on the above page.
  3. Test scriplets here: https://dev-pages.brave.software/filtering/scriptlets.html

Additional Information
@cuba cuba mentioned this issue May 30, 2023
Merged
11 tasks
cuba added a commit that referenced this issue Jul 24, 2023
@cuba
Fix #7539: Add network level standard mode (#7540)
397c715 
* Add network level aggressive mode

* Optimize loading filter lists

* Ensure our stats handle aggressive mode properly

* Fix third party check for stats and request blocking

* Make youtube adblocking always aggressive

* Fix comment
@iccub iccub added this to the 1.57 milestone Jul 28, 2023
@cuba cuba added the QA/Yes label Aug 30, 2023
@Uni-verse
Copy link
Contributor

Verified on iPad (7th Gen) running iPadOS 16.3.1 using version 1.57 (23.9.4.13)

Example Example
IMG_1213 IMG_1214

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@cuba
Fix brave/brave-ios#7539: Add network level standard mode (brave/brav…
f0a4d51 
…e-ios#7540)

* Add network level aggressive mode

* Optimize loading filter lists

* Ensure our stats handle aggressive mode properly

* Fix third party check for stats and request blocking

* Make youtube adblocking always aggressive

* Fix comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
QA Pass - iPad QA/Yes release-notes/include
Projects
None yet
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7539: Add network level standard mode brave/brave-ios
3 participants
@cuba @iccub @Uni-verse