Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update NTP images #7467

Closed
anthonypkeane opened this issue May 16, 2023 · 2 comments · Fixed by #7634
Closed

Update NTP images #7467

anthonypkeane opened this issue May 16, 2023 · 2 comments · Fixed by #7634
Assignees
@kylehickinson
Labels
enhancement Epic: NTP QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@anthonypkeane
Copy link

anthonypkeane commented May 16, 2023 •
edited
Loading

Description:

Please update the new NTP images

@aguscruiz can you please provide the images for iOS

Slack: https://bravesoftware.slack.com/archives/C07HD31EZ/p1684269417070739
@anthonypkeane anthonypkeane added the blocked: needs design Needs design before work can commence label May 16, 2023
@aguscruiz
Copy link
Collaborator

@petemill was working on optimizing them. He would have the latest version of them 👍

@kylehickinson kylehickinson mentioned this issue Jun 22, 2023
Merged
11 tasks
@kylehickinson kylehickinson added this to the 1.53 milestone Jun 23, 2023
@kylehickinson kylehickinson self-assigned this Jun 23, 2023
kylehickinson added a commit that referenced this issue Jun 23, 2023
@kylehickinson
Fix #7467: Add support for using component updater to fetch backgroun…
34a90d9 
…d & sponsored images (#7634)
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 using version 1.53 (23.7.6.16)

  • Verified NTP images are updated
  • Verified disabling background images in the settings will not display them on NTP
  • Verified NTP images are on rotation and SI are displayed every 4th tab
Example Example Example Example Example
IMG_3320 2 IMG_3321 2 IMG_3323 2 IMG_3324 2 IMG_3325 2

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7467: Add support for using component updater to …
635f054 
…fetch background & sponsored images (brave/brave-ios#7634)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: NTP QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
4 participants
@kylehickinson @anthonypkeane @aguscruiz @Uni-verse