Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

App crashes when attempting to migrate a legacy wallet #7464

Closed
kylehickinson opened this issue May 16, 2023 · 1 comment · Fixed by #7465
Closed

App crashes when attempting to migrate a legacy wallet #7464

kylehickinson opened this issue May 16, 2023 · 1 comment · Fixed by #7465
Assignees
@kylehickinson
Labels
bug crash Epic: Rewards QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.52

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented May 16, 2023 •
edited
Loading

Description:

In 1.52.x we moved some of the Ledger code on the core side to use mojo, which surfaced an issue with the current legacy wallet migration code and possible threading problems

Steps to Reproduce

  1. On 1.51 and lower: Enable rewards, then go to Rewards Debug settings and tap on "Create Legacy Wallet"
  2. Update to 1.52
  3. Launch and observe crash

Reproduces how often: Easily

Brave Version: 1.52
@kylehickinson kylehickinson added this to the 1.52 milestone May 16, 2023
@kylehickinson kylehickinson self-assigned this May 16, 2023
kylehickinson added a commit that referenced this issue May 16, 2023
@kylehickinson
Fix #7464: Remove legacy ledger wallet migrations
1b29ce0 
The Ledger code in brave-core behaves like a singleton as it uses a global pointer to log, so we can't have more than 1 created. Creating a legacy wallet to do migrations was now crashing because ledger changes in 1.52 to use mojo now expose threading errors.
@kylehickinson kylehickinson mentioned this issue May 16, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue May 16, 2023
@kylehickinson
Fix #7464: Remove legacy ledger wallet migrations (#7465)
2942eff 
The Ledger code in brave-core behaves like a singleton as it uses a global pointer to log, so we can't have more than 1 created. Creating a legacy wallet to do migrations was now crashing because ledger changes in 1.52 to use mojo now expose threading errors.
@hffvld
Copy link
Collaborator

hffvld commented Jun 23, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5] 
Version: 1.52 (23.6.22.18)
BraveCore: 1.52.125 (114.0.5735.110)

STEPS:

  1. On 1.51 and lower: Enable rewards, then go to Rewards Debug settings and tap on Create Legacy Wallet
  2. Update to 1.52
  3. Launch and Verify

ACTUAL RESULTS:

  • Verified that Brave is not crashing
Legacy.wallet.mov

@Uni-verse Uni-verse mentioned this issue Aug 18, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7464: Remove legacy ledger wallet migrations (bra…
961cf6c 
…ve/brave-ios#7465)

The Ledger code in brave-core behaves like a singleton as it uses a global pointer to log, so we can't have more than 1 created. Creating a legacy wallet to do migrations was now crashing because ledger changes in 1.52 to use mojo now expose threading errors.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug crash Epic: Rewards QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.52
Development

Successfully merging a pull request may close this issue.

Fix #7464: Remove legacy ledger wallet migrations brave/brave-ios
3 participants
@kylehickinson @Uni-verse @hffvld