Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update Safe Browsing setting text, follow up to #7373 #7430

Closed
iccub opened this issue May 10, 2023 · 1 comment · Fixed by #7473
Closed

Update Safe Browsing setting text, follow up to #7373 #7430

iccub opened this issue May 10, 2023 · 1 comment · Fixed by #7473
Assignees
@iccub
Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include security
Milestone
1.52

Comments

@iccub
Copy link
Contributor

iccub commented May 10, 2023

See #7373
@iccub iccub mentioned this issue May 10, 2023
Closed
2 tasks
iccub added a commit that referenced this issue May 17, 2023
@iccub
Fix #7430: Update Safe Browsing setting text.
cb0e344
iccub added a commit that referenced this issue May 17, 2023
@iccub
Fix #7430: Update Safe Browsing setting text.
01b4aa4
@iccub iccub mentioned this issue May 17, 2023
Merged
11 tasks
@iccub iccub self-assigned this May 17, 2023
@iccub iccub added this to the 1.52 milestone May 17, 2023
iccub added a commit that referenced this issue May 17, 2023
@iccub @cuba
Fix #7430: Update Safe Browsing setting text. (#7473)
d00a5bf 
Co-authored-by: Jacob Sikorski <[email protected]>
@hffvld
Copy link
Collaborator

hffvld commented Jun 13, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5] 
Version: 1.52 (23.6.9.13)
BraveCore: 1.52.117 (114.0.5735.90)

STEPS:

  1. Launch Brave > Three-dot Menu
  2. Settings > Brave Shields & Privacy
  3. Scroll down and find Block Dangerous Websites > Verify title and subtitle strings

ACTUAL RESULTS:

  • Verified that the new string for the title is Block Dangerous Websites
  • Verified that the new string for the subtitle is Safe Browsing protects against websites which are known to be dangerous. Learn More
  • Verified that Block Dangerous Websites is set to ON by default
  • Verified that tapping onLearn More in Safe Browsing protects against websites which are known to be dangerous. Learn More is redirecting to https://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave
1 2
1 2

@Uni-verse Uni-verse mentioned this issue Aug 18, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub @cuba
Fix brave/brave-ios#7430: Update Safe Browsing setting text. (brave/b…
9612435 
…rave-ios#7473)

Co-authored-by: Jacob Sikorski <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include security
Projects
None yet
Milestone
1.52
Development

Successfully merging a pull request may close this issue.

Fix #7430: Update Safe Browsing setting text. brave/brave-ios
4 participants
@fmarier @iccub @Uni-verse @hffvld