Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Headers for responses should be case-insensitive #7394

Closed
Brandon-T opened this issue May 5, 2023 · 1 comment · Fixed by #7395
Closed

Headers for responses should be case-insensitive #7394

Brandon-T opened this issue May 5, 2023 · 1 comment · Fixed by #7395

Comments

@Brandon-T
Copy link
Collaborator

Brandon-T commented May 5, 2023

Description:

  • Currently when Brave-iOS parses headers, it parses them case-insensitive

Steps to Reproduce

  1. None

Actual result:

  • Headers are Case-Sensitive parsed which can cause hidden bugs

Expected result:

  • Should parse headers case-insensitive

Test Plan:

  • In the PR :)
@Brandon-T Brandon-T added this to the 1.50 milestone May 5, 2023
@Brandon-T Brandon-T self-assigned this May 5, 2023
@Brandon-T Brandon-T modified the milestones: 1.50, 1.51 May 5, 2023
iccub pushed a commit that referenced this issue May 5, 2023
iccub pushed a commit that referenced this issue May 5, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented May 15, 2023

Verified on iPhone X running iOS 16.3.1 using version 1.51 (23.5.11.17)

Using Test Plan in #7395 (comment)

NTP Backgrounds

  • Ensured that background images on NTP are showing
  • Ensured that sponsored images are showing on NTP
  • Ensured that disabling background images in settings will not display them on NTP
  • Ensured background/sponsored image are shown while using VPN
Example Example Example Example Example Example
IMG_3177 IMG_3178 IMG_3179 IMG_3180 2 IMG_3182 IMG_3183

Adblock lists

  • Ensured that page has true for all values with shields up and null with shields down when loading https://test-pages.privacytests.org/tracking_content.html.
  • Ensured that app launches relatively quickly with many filters enabled in the content filtering.
  • Ensured that cosmetic filtering is working when loading twitter.com or reddit.com
  • Ensured that script loading test page is passing, showing true when shields are up and null when shields down - https://dev-pages.brave.software/filtering/scriptlets.html
Example Example Example Example Example Example
IMG_3185 IMG_3187 IMG_3188 IMG_3189 IMG_3190 IMG_3191

Playlist Sharing

  • Confirmed downloading and saving a shared playlist is working using bsa-sample playlist.
  • Confirmed shared playlist folder loads in Brave Playlist and user is able to use playback.
  • Confirmed deleting shared playlist folder.
Example Example Example Example
IMG_3195 IMG_3196 IMG_3197 IMG_3198

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants