Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update pending transactions to support all networks for a coin type #7295

Closed
StephenHeaps opened this issue Apr 20, 2023 · 1 comment · Fixed by #7424
Closed

Update pending transactions to support all networks for a coin type #7295

StephenHeaps opened this issue Apr 20, 2023 · 1 comment · Fixed by #7424
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.52

Comments

@StephenHeaps
Copy link
Contributor

Description:

With the changes in brave/brave-core#17986, we are now able to fetch transactions for all networks on each coin type (current logic uses the selected network for each coin type). We should update the pending requests to fetch transactions for all networks on a given coin type, and update Transaction Confirmation to make sure the correct network for the transaction is displayed (no longer guaranteed be the selected network for the coin type).

GetAllTransactionInfo now accepts a chain_id parameter, and the chain_id is stored on each TransactionInfo model.

Requires BraveCore v1.52.x
StephenHeaps added a commit that referenced this issue May 3, 2023
@StephenHeaps
Fix for only showing transactions from the selected network (existing…
544ece6 
… behaviour) until #7295 (need to make sure correct network is shown for transaction)
@StephenHeaps StephenHeaps self-assigned this May 4, 2023
StephenHeaps added a commit that referenced this issue May 4, 2023
@StephenHeaps @kylehickinson @tmancey
Fix #7378: Bump Brave Core to 1.52.84 (#7379)
4b3df9d 
* Update ledger code for 1.52.x

* Update BraveCore to v1.52.42

* Update BraveCore to v1.52.54

* Selected network per origin changes

* Implement Brave Ads rotating hash for iOS (#7344)

* Update BraveCore to v1.52.84

* Fix for only showing transactions from the selected network (existing behaviour) until #7295 (need to make sure correct network is shown for transaction)

---------

Co-authored-by: Kyle Hickinson <[email protected]>
Co-authored-by: Terry Mancey <[email protected]>
@StephenHeaps StephenHeaps mentioned this issue May 10, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps added this to the 1.52 milestone May 10, 2023
StephenHeaps added a commit that referenced this issue May 10, 2023
@StephenHeaps
Fix #7295: Show pending transactions from all networks (#7424)
bb503f1 
* Initial support for displaying & confirming pending transactions from all networks

* Add unit test to verify network for TransactionConfirmation. Sort transactions in confirmation by createdDate for deterministic order.

* Fetch transactions from known networks only until #7429
@Pavneet-Sing Pavneet-Sing mentioned this issue May 31, 2023
Closed
@srirambv
Copy link
Contributor

srirambv commented Jun 6, 2023

Verification passed on iPhone 13 with iOS 16.5 running 1.52 (23.6.1.15)

  • Verified steps from #7424
  • Verified pending transaction button is shown irrespective of which network is set as active network
  • Verified Transaction Completed message is shown once the transaction is confirmed
  • Verified View Receipt shows the correct network
  • Verified confirm/reject transaction action works as expected
  • Logged #7572
7295.MP4

@Uni-verse Uni-verse mentioned this issue Aug 18, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps @kylehickinson @tmancey
Fix brave/brave-ios#7378: Bump Brave Core to 1.52.84 (brave/brave-ios…
54421e1 
…#7379)

* Update ledger code for 1.52.x

* Update BraveCore to v1.52.42

* Update BraveCore to v1.52.54

* Selected network per origin changes

* Implement Brave Ads rotating hash for iOS (brave/brave-ios#7344)

* Update BraveCore to v1.52.84

* Fix for only showing transactions from the selected network (existing behaviour) until brave/brave-ios#7295 (need to make sure correct network is shown for transaction)

---------

Co-authored-by: Kyle Hickinson <[email protected]>
Co-authored-by: Terry Mancey <[email protected]>
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7295: Show pending transactions from all networks (…
414449c 
…brave/brave-ios#7424)

* Initial support for displaying & confirming pending transactions from all networks

* Add unit test to verify network for TransactionConfirmation. Sort transactions in confirmation by createdDate for deterministic order.

* Fetch transactions from known networks only until brave/brave-ios#7429
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52
Development

Successfully merging a pull request may close this issue.

Fix #7295: Show pending transactions from all networks brave/brave-ios
3 participants
@StephenHeaps @srirambv @Uni-verse