Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Use Symbol when adding variables to xhr objects #7272

Closed
cuba opened this issue Apr 18, 2023 · 1 comment · Fixed by #7273
Closed

Use Symbol when adding variables to xhr objects #7272

cuba opened this issue Apr 18, 2023 · 1 comment · Fixed by #7273
Assignees
@cuba
Labels
enhancement QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.51

Comments

@cuba
Copy link
Contributor

cuba commented Apr 18, 2023

Description:

In order to avoid conflicts with other code, we attach variables to xhr objects using Symbol instead of a static variable name. This should prevent conflicts and also unwanted manipulation/extraction of these variables
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in TrackingProtectionStats.js
f81d29b
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in RewardsReportingScript.js
6eabd03
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in TrackingProtectionStats.js
7ac539a
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in RewardsReportingScript.js
b80a342
@cuba cuba mentioned this issue Apr 18, 2023
Merged
11 tasks
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in TrackingProtectionStats.js
bc863ba
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in RewardsReportingScript.js
f38a0d5
cuba added a commit that referenced this issue Apr 18, 2023
@cuba
Fix #7272: Use Symbol in RewardsReportingScript.js
441a4b1
@iccub iccub added this to the 1.51 milestone Apr 19, 2023
iccub pushed a commit that referenced this issue Apr 19, 2023
@cuba
Fix #7272: Use symbol in scripts (#7273)
175a649
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.3.1 using version 1.51 (23.4.28.17)

Testing based on test plan in #7273 (comment)

NOTE - upgraded profile scenarios will be tested by default in the manual pass for rewards / blocking count

  • Ensured creating rewards profile is working on new profile as well as upgraded profile
  • Ensured ads are being shown
Example Example Example
IMG_3115 2 IMG_3116 2 IMG_3117 2
  • Ensured that blocked counts are shown in shields panel
  • Ensured that trackers are listed/updated in privacy hub stats
Example Example Example Example
IMG_3118 2 IMG_3122 2 IMG_3123 2 IMG_3124 2

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@cuba
Fix brave/brave-ios#7272: Use symbol in scripts (brave/brave-ios#7273)
4d6c1ac
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
enhancement QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.51
Development

Successfully merging a pull request may close this issue.

Fix #7272: Use symbol in scripts brave/brave-ios
3 participants
@cuba @iccub @Uni-verse