Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[hackerone] Show a prompt for QR-code scanned URLs #7260

Closed
stoletheminerals opened this issue Apr 14, 2023 · 1 comment · Fixed by #7319
Closed

[hackerone] Show a prompt for QR-code scanned URLs #7260

stoletheminerals opened this issue Apr 14, 2023 · 1 comment · Fixed by #7319
Assignees
@stoletheminerals
Labels
enhancement priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include security
Milestone
1.51

Comments

@stoletheminerals
Copy link
Contributor

We should show a prompt before navigating to a URL that was scanned with the QR-code scanner.

https://hackerone.com/reports/1946534
@anthonypkeane anthonypkeane added the blocked: needs design Needs design before work can commence label Apr 15, 2023
@iccub iccub removed the blocked: needs design Needs design before work can commence label Apr 19, 2023
@stoletheminerals stoletheminerals added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 21, 2023
@stoletheminerals stoletheminerals mentioned this issue Apr 24, 2023
Merged
11 tasks
@stoletheminerals stoletheminerals self-assigned this Apr 24, 2023
@kylehickinson kylehickinson added this to the 1.51 milestone Apr 26, 2023
kylehickinson pushed a commit that referenced this issue Apr 26, 2023
@stoletheminerals
Fix #7260: Don't auto submit URL from a QR code (#7319)
7eb63d9
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.3.1 & iPad (9th Gen) running iOS 15.6.1 using 1.51 (23.4.28.18)

Using Test Plan in #7319 (comment)

  • Verified scanning QR using omnibar doesn't auto-submit URL and shows URL selected in normal and private mode.
  • Verified scanning URL doesn't auto-submit on upgraded profile.
  • Verified scanning QR works and loads the URL successfully.
  • Verified scanning QR works with bottom bar and top bar modes.
  • Verified scanning has not regressed on normal and private tabs
Bottom Bar Top Bar Private Tabs iPad
IMG_3093 IMG_3095 2 IMG_3094 IMG_0227 4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@stoletheminerals
Fix brave/brave-ios#7260: Don't auto submit URL from a QR code (brave…
3ed8c44 
…/brave-ios#7319)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stoletheminerals stoletheminerals

Labels
enhancement priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include security
Projects
None yet
Milestone
1.51
Development

Successfully merging a pull request may close this issue.

Fix #7260: Don't auto submit URL from a QR code brave/brave-ios
5 participants
@kylehickinson @iccub @anthonypkeane @stoletheminerals @Uni-verse