Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Move Block Popups toggle out of Brave Shields & Privacy settings #7247

Closed
antonok-edm opened this issue Apr 13, 2023 · 1 comment · Fixed by #7330
Closed

Move Block Popups toggle out of Brave Shields & Privacy settings #7247

antonok-edm opened this issue Apr 13, 2023 · 1 comment · Fixed by #7330
Assignees
@iccub
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.51

Comments

@antonok-edm
Copy link
Collaborator

The setting doesn't really full under the category of Shields or Privacy. It could be moved to general settings, or removed altogether (note that brave-core does not have an analogous setting).
iccub added a commit that referenced this issue Apr 25, 2023
@iccub
Fix #7247: Move block popups setting to general settings section.
059413a
@iccub iccub self-assigned this Apr 25, 2023
@iccub iccub added this to the 1.51 milestone Apr 25, 2023
@iccub iccub mentioned this issue Apr 25, 2023
Merged
11 tasks
iccub added a commit that referenced this issue Apr 25, 2023
@iccub
Fix #7247: Move block popups setting to general settings section. (#7330
889caf3 
)
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.3.1 & iPad (9th Gen) running iOS 15.6.1 using 1.51 (23.4.28.18)

  • Confirmed Block Popups toggle is moved to General Settings
  • Confirmed Block Popups toggle state is retained on upgraded profile
  • Confirmed Block Popups toggle is enabled by default on new profile
Example Example
IMG_3096 IMG_3097
IMG_0230 3 IMG_0229 3

@Uni-verse Uni-verse mentioned this issue Jul 18, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Fix brave/brave-ios#7247: Move block popups setting to general settin…
7949573 
…gs section. (brave/brave-ios#7330)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.51
Development

Successfully merging a pull request may close this issue.

Fix #7247: Move block popups setting to general settings section. brave/brave-ios
3 participants
@iccub @Uni-verse @antonok-edm