Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet: Activity tab #7198

Closed
StephenHeaps opened this issue Apr 4, 2023 · 1 comment · Fixed by #7248
Closed

Wallet: Activity tab #7198

StephenHeaps opened this issue Apr 4, 2023 · 1 comment · Fixed by #7248
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.51

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Apr 4, 2023 •
edited
Loading

Description:

Integrate activity tab for transactions in wallet.

Networks & Accounts filter separated to #7233
@StephenHeaps StephenHeaps self-assigned this Apr 4, 2023
@StephenHeaps StephenHeaps added this to Web3 Apr 4, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Apr 12, 2023
This was referenced Apr 12, 2023
Closed
Merged
StephenHeaps added a commit that referenced this issue Apr 19, 2023
@StephenHeaps
Fix #7198: Wallet Activity Tab (#7248)
459299a 
* Add Activity tab for displaying user transactions.

* Update `TabbedPageViewController` so the tabs scroll horizontally now; this should resolve any potential truncation issues with new tabs after localization.

* Improve initial load performance by displaying transactions prior to fetching Solana estimated transaction fees and asset prices. 

* Filter out rejected transactions
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Apr 19, 2023
@iccub iccub added this to the 1.51 milestone Apr 19, 2023
@srirambv
Copy link
Contributor

srirambv commented May 8, 2023

Verification passed on the following devices running 1.

  • Verified steps from #7248
  • Verified Activity tab lists all the submitted and unsubmitted tranactions
  • Verified rejected transactions are not listed
  • Verified transactions from all networks are listed
  • Verified clicking on the transaction shows the details as expected
iPhone 13 (iOS 16.4.1) iPad Pro (16.4 Beta 4)
7198-iPhone.13.MP4
7198-iPad.Pro.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7198: Wallet Activity Tab (brave/brave-ios#7248)
637ee44 
* Add Activity tab for displaying user transactions.

* Update `TabbedPageViewController` so the tabs scroll horizontally now; this should resolve any potential truncation issues with new tabs after localization.

* Improve initial load performance by displaying transactions prior to fetching Solana estimated transaction fees and asset prices. 

* Filter out rejected transactions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51
Development

Successfully merging a pull request may close this issue.

Fix #7198: Wallet Activity Tab brave/brave-ios
4 participants
@StephenHeaps @iccub @srirambv @Uni-verse