Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Origin Password section shown for Add Solana Account #7175

Closed
StephenHeaps opened this issue Mar 30, 2023 · 1 comment · Fixed by #7177
Closed

Origin Password section shown for Add Solana Account #7175

StephenHeaps opened this issue Mar 30, 2023 · 1 comment · Fixed by #7177

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Mar 30, 2023

Description:

Json password field is shown when json is detected in private key field, but json import is disabled for Solana

Steps to Reproduce

  1. Open Add Account view and select Solana
  2. Enter any json (ex. {}) in the private key field
  3. Observe Origin Password section now shown

Actual result:

Simulator Screen Shot - iPhone 14 Pro - 2023-03-30 at 17 32 13

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 16.3.1 running 1.49 (23.3.31.9)

  • Verified Origin password section is not shown for adding Solana account
  • Verified Origin password section is still shown for adding Ethereum account
7175-iPhone.XR.MP4

Verification passed on iPad Pro with iOS 16.4 Beta 4 running 1.49 (23.3.31.9)

  • Verified Origin password section is not shown for adding Solana account
  • Verified Origin password section is still shown for adding Ethereum account
7175-iPad.Pro.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants