Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

In an RSS-only Brave News state, the "New Content Available" button comes up every time NTP is viewed #7059

Closed
kylehickinson opened this issue Mar 8, 2023 · 1 comment · Fixed by #7061
Closed

In an RSS-only Brave News state, the "New Content Available" button comes up every time NTP is viewed #7059

kylehickinson opened this issue Mar 8, 2023 · 1 comment · Fixed by #7061
Assignees
@kylehickinson
Labels
bug Epic: Brave News QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.49

Comments

@kylehickinson
Copy link
Collaborator

Description:

The purple "New Content Available" button shows up every time you come back from visiting a link in a RSS-only feed

Steps to Reproduce

  1. Enable Brave News and unfollow Top Sources (and any other sources you're following)
  2. Follow an RSS feed of your choosing (replicated with Daring Fireball: https://daringfireball.net/feeds/main)
  3. Visit an RSS feed's link
  4. Click the back button to go back to NTP/Brave News

Actual result:

The "New Content Available" button appears every time

Expected result:

It should not appear unless the sources expire (24 hours) or you edit your sources

Reproduces how often:

Easily
@kylehickinson kylehickinson self-assigned this Mar 8, 2023
kylehickinson added a commit that referenced this issue Mar 8, 2023
@kylehickinson
Fix #7059: Don't show Brave News reload button on RSS-only feed
64c81e7
@kylehickinson kylehickinson mentioned this issue Mar 8, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Mar 8, 2023
@kylehickinson
Fix #7059: Don't show Brave News reload button on RSS-only feed
2c97749
@kylehickinson kylehickinson added this to the 1.49 milestone Mar 9, 2023
kylehickinson added a commit that referenced this issue Mar 9, 2023
@kylehickinson
Fix #7059: Don't show Brave News reload button on RSS-only feed (#7061)
fec451e
@Uni-verse
Copy link
Contributor

Verified using 1.49 (23.3.23.15) on iPhone 12 Pro running iOS 16.4 while running though #7063 (comment)

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7059: Don't show Brave News reload button on RSS-…
6453738 
…only feed (brave/brave-ios#7061)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Brave News QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #7059: Don't show Brave News reload button on RSS-only feed brave/brave-ios
2 participants
@kylehickinson @Uni-verse