Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Remove SDWebImage SVG #7026

Closed
Brandon-T opened this issue Feb 27, 2023 · 3 comments · Fixed by brave/brave-core#17400 or #7881
Closed

Remove SDWebImage SVG #7026

Brandon-T opened this issue Feb 27, 2023 · 3 comments · Fixed by brave/brave-core#17400 or #7881
Assignees
@nuo-xu
Labels
enhancement QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.60

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • SDWebImage SVG crashes a lot when parsing SVGs
  • We should remove it and use the Brave-Core SVG parser

Brave Version:

  • 1.48.x
@Brandon-T Brandon-T added this to the 1.49 milestone Feb 27, 2023
@Brandon-T Brandon-T self-assigned this Feb 27, 2023
@Brandon-T Brandon-T mentioned this issue Feb 27, 2023
Merged
25 tasks
@nuo-xu
Copy link
Contributor

nuo-xu commented Mar 3, 2023

Reopen this issue for Wallet team to remove the SDWebImage SVG coder and use the new api https://github.com/brave/brave-core/blob/master/ios/browser/api/web_image/web_image.h to load svg image
also label qa/yes to make sure nothing is broken.

@nuo-xu nuo-xu reopened this Mar 3, 2023
@nuo-xu nuo-xu added the QA/Yes label Mar 3, 2023
@nuo-xu nuo-xu removed the QA/No label Mar 3, 2023
@nuo-xu nuo-xu removed this from the 1.49 milestone Mar 9, 2023
@nuo-xu nuo-xu mentioned this issue Aug 16, 2023
Merged
11 tasks
nuo-xu added a commit that referenced this issue Aug 18, 2023
@nuo-xu
Fix #7026: Remove SDWebImageSVGNativeCoder and use `WebImageDownloa…
639c7d4 
…der` to decode web images in Wallet (#7881)
@nuo-xu nuo-xu self-assigned this Aug 18, 2023
@iccub iccub mentioned this issue Aug 28, 2023
Closed
@iccub iccub added this to the 1.59 milestone Oct 6, 2023
@nuo-xu nuo-xu removed this from the 1.59 milestone Oct 6, 2023
@nuo-xu
Copy link
Contributor

nuo-xu commented Oct 6, 2023 •
edited
Loading

keep 1.59 milestone since this has been shipped in 1.57 but not verified.

@nuo-xu nuo-xu added this to the 1.59 milestone Oct 6, 2023
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.7 using version 1.60 (23.11.12.17)

Example Example Example Example
IMG_3628 2 IMG_3629 2 IMG_3630 2 IMG_3631
1.58.2 1.60
IMG_3634 2 IMG_3635 2

@Uni-verse Uni-verse mentioned this issue Dec 20, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#7026: Remove SDWebImageSVGNativeCoder and use `…
ed4c4bb 
…WebImageDownloader` to decode web images in Wallet (brave/brave-ios#7881)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nuo-xu nuo-xu

Labels
enhancement QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.60
4 participants
@nuo-xu @Brandon-T @iccub @Uni-verse