Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Display "Never Saved" domains in password sync in a separate section like desktop #6991

Closed
kylehickinson opened this issue Feb 22, 2023 · 1 comment · Fixed by #7052
Closed

Display "Never Saved" domains in password sync in a separate section like desktop #6991

kylehickinson opened this issue Feb 22, 2023 · 1 comment · Fixed by #7052
Assignees
@soner-yuksel
Labels
enhancement Epic: Sync Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.50

Comments

@kylehickinson
Copy link
Collaborator

Description:

When you have password sync and sync websites that you've chosen to "never save"/prompt to save on desktop they will sync as empty passwords in iOS. These should appear under a "Never Saved" section similar to desktop

image
@soner-yuksel soner-yuksel self-assigned this Feb 22, 2023
@soner-yuksel soner-yuksel added this to the 1.49 milestone Feb 22, 2023
@soner-yuksel soner-yuksel mentioned this issue Mar 3, 2023
Merged
11 tasks
@iccub iccub removed this from the 1.49 milestone Mar 20, 2023
@soner-yuksel soner-yuksel added this to the 1.50 milestone Mar 22, 2023
soner-yuksel added a commit that referenced this issue Mar 22, 2023
@soner-yuksel
Fix #6991: Display "Never Saved" domains in password sync (#7052)
b070cea
StephenHeaps pushed a commit that referenced this issue Mar 23, 2023
@soner-yuksel @StephenHeaps
Fix #6991: Display "Never Saved" domains in password sync (#7052)
7d43743
StephenHeaps pushed a commit that referenced this issue Mar 23, 2023
@soner-yuksel @StephenHeaps
Fix #6991: Display "Never Saved" domains in password sync (#7052)
eb76f7d
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 17, 2023 •
edited
Loading

Verified on iPhone X running iOS 16.3.1 & iPad (7th Gen) running iPadOS 16.4 using version 1.50 (23.4.17.16)

  • Ensured that logins marked as never save appear in the Never Saved section in the iOS password manager
  • Ensured that login entries in the Never Saved section can be viewed and deleted via gestures.
  • Ensured that login entries in the Never Saved section can be deleted in edit mode.
  • Ensured that Never Saved logins show up on an existing profile (1.49.1 -> 1.50)
Example Example Example Example Example Example
Screenshot 2023-04-17 at 4 55 54 PM IMG_2972 IMG_2973 2 IMG_2974 IMG_1048 IMG_1049

@Uni-verse Uni-verse mentioned this issue May 5, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#6991: Display "Never Saved" domains in password s…
d835765 
…ync (brave/brave-ios#7052)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement Epic: Sync Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.50
Development

Successfully merging a pull request may close this issue.

Fix #6991: Display "Never Saved" domains in password sync brave/brave-ios
4 participants
@kylehickinson @soner-yuksel @iccub @Uni-verse