Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Google Oauth window does not autoclose after success #6966

Closed
paymog opened this issue Feb 17, 2023 · 1 comment · Fixed by #7797
Closed

Google Oauth window does not autoclose after success #6966

paymog opened this issue Feb 17, 2023 · 1 comment · Fixed by #7797

Comments

@paymog
Copy link

paymog commented Feb 17, 2023

Description:

I recently implemented Google Oauth on my website with popup behavior. However, since popup is not supported on mobile, a new tab is opened to go through the oauth flow. After the flow succeeds, Brave iOS does not autoclose the tab. However, Safari does autoclose the tab. This behavior persists even with shields turned off for accounts.google.com which is the domain that does the oauth.

Steps to Reproduce

  1. Visit https://lookielooapp.com/signup on Brave iOS
  2. Try signing in with google
  3. See new tab open up and then seemingly hang
  4. go back to the Lookieloo tab
  5. see that you're logged in
  6. try the flow with Safari/chrome

Actual result:

The Oauth consent flow seems to hang indefinitely

image

Even though the actual application successfully logs in

image

Expected result:

I expect brave to autoclose the tab after success, just like chrome and safari.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version:

Version 1.47 (23.2.1.14)
BraveCore 1.47.189 (109.0.5414.119)
Device iPhone14,5 (iOS 16.2)

  • Can you reproduce this issue with the most recent build from TestFlight? didn't try
  • Can you reproduce this issue with the previous version of the current build from TestFlight? didn't try
  • Can you reproduce this issue with the current build from AppStore? I'm up to date according to the app store

Device details:

Device iPhone14,5 (iOS 16.2)

Website problems only:

  • did you check with Brave Shields down? yes
  • did you check in Safari/Firefox (WkWebView-based browsers)? yes

Additional Information

@hffvld
Copy link
Collaborator

hffvld commented Aug 17, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 16.6]
- iPad Air [iPadOS 16.5]
Brave build: 1.57 (23.8.16.21)
BraveCore: 1.57.47 (116.0.5845.96)

STEPS:

  1. Launch Brave
  2. Open https://lookielooapp.com/signup or https://tunein.com
  3. Sign up/Sign in with Google
  4. Enter login credentials > Verify

ACTUAL RESULTS:

  • Verified that Sign up/Sign in with Google is working
  • Verified that blank page is self-closed after sign-in is done

iPhone

ios_google.oauth.mov

iPad

ipad_google.oauth.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.