Unable to add custom network via panel prompt

[srirambv]

Description:

Unable to add custom network via panel prompt

Steps to Reproduce

1. Visit https://chainlist.org
2. Select a network and try to add
3. Approve prompt shows up twice but never adds the network to the list. For some network it keeps prompting and never adds it

Actual result:

Add.Network.MP4

Expected result:

Should be able to add a custom network

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
• Can you reproduce this issue with the current build from AppStore? Yes

Device details:

All devices

Website problems only:

• did you check with Brave Shields down? NA
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

cc: @nuo-xu @StephenHeaps

[StephenHeaps]

It looks like adding Astar network from chainlist.org fails, it does not add the network on desktop either ('Approve' button doesn't work) 🤔. I need to investigate a bit more here. cc @darkdh. Edit: This occurs when the RPC calls for the network fail; we don't add the network.

For some other networks I have tested there does seem to be an iOS bug here that causes 'Add Network' to be shown a second time after you approve it once. The second time this view appears, you can tap 'Cancel' or 'Approve' to get around this bug, after which 'Switch Network' will be shown correctly. I am investigating a fix for this.

iOS.add.network.mov

[srirambv]

Verification passed on the following devices running 1.49 (23.3.9.17)

• Verified steps from #7047
• Verified adding a custom token works as expected
• Verified trying to add Astar network fails and shows error message
• Encountered #7074 for iOS 16 Beta

iPhone 7+ (iOS 15.7.3)	iPhone XR (iOS 16.3.1)