Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No favorite sites in the widget #6859

Closed
A-t-s-u-s-h-i opened this issue Feb 2, 2023 · 1 comment · Fixed by #7050
Closed

No favorite sites in the widget #6859

A-t-s-u-s-h-i opened this issue Feb 2, 2023 · 1 comment · Fixed by #7050
Assignees
@kylehickinson
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.49

Comments

@A-t-s-u-s-h-i
Copy link

Description:

There are several reports that widget doesn’t show any favorite sites. It is hardly reproducible. But the same reports are increasing on Apply AppStore Review little by little.

Actual result:

iPhone SE(2nd gen)/iOS16.1.1
image1 (1)
unnamed

Expected result:

The widget shows favorite sites.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Hard to reproduce intentionally.

Device details:

I got details from 2 users so far.(But more users have reported)

  • iPhone SE(2nd gen)/iOS16.1.1
  • Unknown device/iOS16.2
kylehickinson added a commit that referenced this issue Mar 3, 2023
@kylehickinson
Fix #6859: Ensure valid favicon image sizes are used within fav widgets
99f586b 
Also fixes the overlay border not being visible for transparent icons
@kylehickinson kylehickinson mentioned this issue Mar 3, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Mar 3, 2023
@kylehickinson
Fix #6859: Ensure valid favicon image sizes are used within fav widge…
3746ac0 
…ts (#7050)

Also fixes the overlay border not being visible for transparent icons
@kylehickinson kylehickinson added this to the 1.49 milestone Mar 3, 2023
@kylehickinson kylehickinson self-assigned this Mar 3, 2023
@Uni-verse
Copy link
Contributor

Verified using 1.49 (23.3.21.15) on the following device(s):

iPhone XR, iOS 15.5
iPad (7th Gen), iPadOS 16.3.1
iPhone 12 Pro, iOS 16.4

  • Ensured favorite sites are shown in the widget.
  • Ensured that adding new favorites will show up in the widget.
  • Ensured upgrading from a previous app version with existing favorites widget is successful and all favorites are kept.
Example Example
IMG_0315 IMG_1045

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#6859: Ensure valid favicon image sizes are used w…
d956eee 
…ithin fav widgets (brave/brave-ios#7050)

Also fixes the overlay border not being visible for transparent icons
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #6859: Ensure valid favicon image sizes are used within fav widgets brave/brave-ios
3 participants
@kylehickinson @Uni-verse @A-t-s-u-s-h-i