Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add custom filter list URLs #6841

Closed
cuba opened this issue Jan 26, 2023 · 1 comment · Fixed by #6857
Closed

Add custom filter list URLs #6841

cuba opened this issue Jan 26, 2023 · 1 comment · Fixed by #6857

Comments

@cuba
Copy link
Contributor

cuba commented Jan 26, 2023

Description:

Add the ability to add custom filter lists similar to desktop found in the following page:

Screenshot 2023-01-26 at 3 28 34 PM

Additional Information

cuba added a commit that referenced this issue Jan 26, 2023
cuba added a commit that referenced this issue Jan 26, 2023
cuba added a commit that referenced this issue Jan 30, 2023
cuba added a commit that referenced this issue Feb 1, 2023
cuba added a commit that referenced this issue Feb 1, 2023
cuba added a commit that referenced this issue Feb 1, 2023
cuba added a commit that referenced this issue Feb 1, 2023
cuba added a commit that referenced this issue Feb 1, 2023
cuba added a commit that referenced this issue Feb 1, 2023
cuba added a commit that referenced this issue Feb 2, 2023
cuba added a commit that referenced this issue Feb 2, 2023
cuba added a commit that referenced this issue Feb 3, 2023
cuba added a commit that referenced this issue Feb 3, 2023
cuba added a commit that referenced this issue Feb 3, 2023
cuba added a commit that referenced this issue Feb 3, 2023
cuba added a commit that referenced this issue Feb 3, 2023
cuba added a commit that referenced this issue Feb 3, 2023
cuba added a commit that referenced this issue Feb 7, 2023
cuba added a commit that referenced this issue Feb 7, 2023
cuba added a commit that referenced this issue Feb 7, 2023
cuba added a commit that referenced this issue Feb 7, 2023
cuba added a commit that referenced this issue Mar 15, 2023
cuba added a commit that referenced this issue Mar 20, 2023
cuba added a commit that referenced this issue Mar 22, 2023
cuba added a commit that referenced this issue Mar 22, 2023
cuba added a commit that referenced this issue Mar 22, 2023
cuba added a commit that referenced this issue Mar 22, 2023
cuba added a commit that referenced this issue Mar 24, 2023
cuba added a commit that referenced this issue Mar 25, 2023
cuba added a commit that referenced this issue Mar 25, 2023
cuba added a commit that referenced this issue Mar 29, 2023
cuba added a commit that referenced this issue Mar 31, 2023
cuba added a commit that referenced this issue Apr 3, 2023
cuba added a commit that referenced this issue Apr 5, 2023
cuba added a commit that referenced this issue Apr 6, 2023
@iccub iccub added this to the 1.50 milestone Apr 19, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 26, 2023

Verified on iPhone X running iOS 16.3.1 using version 1.50 (23.4.25.20)

Custom Filter List UI

  • Confirmed custom filter list URLs can be added to the list.
  • Confirmed custom filters can be disabled.
  • Confirmed custom filters can be deleted by swipe gesture or in edit mode.
  • Confirmed duplicate custom filters cannot be added.
  • Confirmed error message is shown for non-https urls in the field.
  • Confirmed multiple custom urls can be added.
  • Confirmed Last updated message when script was last updated is shown in the contents.
  • Confirmed Download failed is shown when custom url fails to load.
Example Example Example Example Example Example Example
IMG_2995 2 IMG_2996 IMG_3005 2 IMG_3006 2 IMG_3007 2 IMG_3010 2 IMG_3011

Shields/Blocking Tests

Test Plan: #6857 (comment)

Using Custom filter URL - https://gist.githubusercontent.com/cuba/f13fce20b8fbd043ac8174e39ba16788/raw/af09db2fbda948dcf7a90781716c51f5e36f2237/TestAdBlockRules.txt

  • Ensured that It will remove a script from https://twitch.tv/ and will result in the blocked count to be 1 (testing script blocking)
  • Ensured that header is removed in https://example.com/ (testing cosmetic filtering)
twitch.tv example.com
IMG_2997 2 IMG_2999
Example Example Example Shields DOWN
IMG_3001 2 IMG_3002 2 IMG_3003 2 IMG_3012 3

Upgraded Profile

  • Ensured custom filter list URLs can be added and are applied on websites when upgrading from 1.49.1 -> 1.50.x
  • Ensured custom filter list URLs can be added and are applied on websites when upgrading from 1.49.x -> 1.50.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants