Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Apply eth_signTransaction UI changes (1.48.x brave-core) #6606

Closed
darkdh opened this issue Dec 7, 2022 · 1 comment · Fixed by #6960
Closed

Apply eth_signTransaction UI changes (1.48.x brave-core) #6606

darkdh opened this issue Dec 7, 2022 · 1 comment · Fixed by #6960
Assignees
@nuo-xu
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.49

Comments

@darkdh
Copy link
Member

darkdh commented Dec 7, 2022

core changes brave/brave-core#16247

Requires UI changes for

  1. Post confirmation showing transaction is signed but will be sent by DApp like

Screen Shot 2022-12-01 at 17 53 49

  1. Handle display for new transaction status Signed
@StephenHeaps StephenHeaps added this to Web3 Dec 7, 2022
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Dec 7, 2022
@darkdh darkdh mentioned this issue Dec 7, 2022
Merged
25 tasks
@StephenHeaps StephenHeaps added this to the 1.48 milestone Feb 15, 2023
@nuo-xu nuo-xu mentioned this issue Feb 16, 2023
Merged
11 tasks
nuo-xu added a commit that referenced this issue Feb 22, 2023
@nuo-xu
Fix #6606: added UI to handle tx different statuses (#6960)
dccca81
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Feb 22, 2023
@iccub iccub modified the milestones: 1.48, 1.49 Feb 23, 2023
@srirambv
Copy link
Contributor

srirambv commented Mar 7, 2023

Verification passed on iPhone XR with iOS 16.3.1 running 1.49 (23.3.3.16)

  • Verified test plan from #6960
  • Verified Transaction Submitted message is shown after a transaction is submitted
  • Verified clicking on View on block explorer in the transaction submitted loads the block explorer
  • Verified once transaction is confirmed the Transaction Submitted message shows option to close or receipt
6606.MP4

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#6606: added UI to handle tx different statuses (b…
a80ce1c 
…rave/brave-ios#6960)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nuo-xu nuo-xu

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #6606: added UI to handle tx different statuses brave/brave-ios
5 participants
@nuo-xu @StephenHeaps @iccub @darkdh @srirambv