Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ads being shown on YouTube. #6411

Closed
cuba opened this issue Nov 17, 2022 · 1 comment · Fixed by #6413
Closed

Ads being shown on YouTube. #6411

cuba opened this issue Nov 17, 2022 · 1 comment · Fixed by #6413

Comments

@cuba
Copy link
Contributor

cuba commented Nov 17, 2022

Description:

Youtube ad-block is not working on first launches

Steps to Reproduce

  1. Launch the app first time
  2. Go directly to YouTube
  3. Watch some videos

Actual result:
Ads are being presented

Expected result:
Ads should not be presented

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced

Brave Version:
1.45

Device details:
Any but slower devices and slower connections suffer more from this.

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Related highly to this: #6261 because it's caused due to ads being shown while the engine is being loaded. If you go to YouTube wile this is happening then you will get ads. Navigating in YouTube does not solve the issue you really need to refresh the page to get rid of ads. This is a very obscure fix.

@cuba cuba added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Nov 17, 2022
@cuba cuba added this to the 1.45.1 milestone Nov 17, 2022
@cuba cuba self-assigned this Nov 17, 2022
@iccub iccub modified the milestones: 1.45.2, 1.45.1 Nov 17, 2022
cuba added a commit that referenced this issue Nov 17, 2022
cuba added a commit that referenced this issue Nov 17, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 17, 2022

Verification completed using version 1.45.1 (22.11.17.19) on the following device(s):

iPhone 12 Pro - iOS 16.x
iPhone XR - iOS 15.x
iPhone X - iOS 14.x
iPads - iPadOS 16.x/15.x

Fresh Profile (1.45.1):

  1. Launch the app first time
  2. Go directly to YouTube
  3. Watch some videos
  • Verified pre-roll ads are not shown on version 1.45.1
  • Verified that once the filter lists are downloaded, the content ads are removed.

0

Note: Some content ads are still shown on initial load after fresh install, All of these will be gone after reloading page a min later. See examples below:

iPad (OS16) iPad (OS15) iPhone X (OS14)
IMG_0781 IMG_0051 IMG_2789

Upgraded Profile (1.44.1 -> 1.45.1):

  1. Installed 1.44.1
  2. Navigate to YouTube
  3. Watch some videos (user should be seeing content ads on initial load)
  4. Open another tab, load a webpage that has ads like yahoo.com or cnn.com
  5. After several minutes (to allow lists to download) upgrade to 1.45.1
  6. Open youtube.com
  7. Watch some videos, confirm no pre-roll ads are shown
  8. open webpage that has ads, confirm no ads are shown
  • Verified pre-roll ads are not shown on version 1.45.1
  • Verified that once the filter lists are downloaded, the content ads are removed.
Example Example
IMG_0785 IMG_0786

Upgraded Profile (1.45 -> 1.45.1)

  1. Installed 1.45
  2. Navigated to YouTube
  3. Watched some videos (user should be seeing content ads on initial load)
  4. Opened another tab, loaded a webpage that has ads like yahoo.com or cnn.com
  5. After several minutes (to allow lists to download) upgraded to 1.45.1
  6. Opened youtube.com
  7. Watched some videos, confirmed no pre-roll ads are shown
  8. opened webpage that has ads, confirmed no ads are shown
  • Verified that pre-roll ads are not shown on upgraded profile.
  • Verified that content ads were not encountered on youtube.com when upgrading from 1.45

0

Additional testing with shields loading can be found here - #6261 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.