Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Issues while scrolling websites with sticky header/footer #631

Closed
danishjafri88 opened this issue Dec 14, 2018 · 2 comments
Closed

Issues while scrolling websites with sticky header/footer #631

danishjafri88 opened this issue Dec 14, 2018 · 2 comments

Comments

@danishjafri88
Copy link
Contributor

danishjafri88 commented Dec 14, 2018

Description:

App becomes unresponsive (loss of FPS maybe), while scrolling (jumps instead of scroll) in websites with sticky footer/Header.
Example: m.indiatimes.com (iPhone, footer) & m.youtube.com (iPad, header)

In certain cases the sticky header/footer may also get clipped by browser container.
Example: m.youtube.com (iPad, header)

Steps to Reproduce

  1. Open either of the two websites above.
  2. Scroll slowly as to hide the top/bottom bars

Actual result:
Loss of responsiveness/ fps and sometimes clipping of sticky header/footer in websites.

Expected result:
No Scroll Issues

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@danishjafri88 danishjafri88 self-assigned this Dec 18, 2018
@danishjafri88
Copy link
Contributor Author

After through research, I found that the issue with indiatimes.com is bad css and script. It's a poorly implemented webpage which has onScroll event listeners and uses a lot of z-indexing. Though this issue is solved in Safari mobile (I am guessing they are somehow ignoring z-index, to which many web developers have responded a solution like https://stackoverflow.com/questions/32875046/ios-9-safari-changing-an-element-to-fixed-position-while-scrolling-wont-paint/43188105#43188105). We can take the approach as mentioned or ignore this completely.

Still looking into the iPad issue for youtube. And the consistent scroll jump when tabs are visible.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 12, 2019

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.12.14)
    • Verified sites listed (m.indiatimes.com and m.youtube.com) did not have scrolling issues on iPad 5th gen in portrait or landscape modes.
  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants