Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add more brave:// URL scheme actions #627

Closed
1 of 2 tasks
kylehickinson opened this issue Dec 14, 2018 · 4 comments
Closed
1 of 2 tasks

Add more brave:// URL scheme actions #627

kylehickinson opened this issue Dec 14, 2018 · 4 comments
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue enhancement good first issue QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Milestone
1.29

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Dec 14, 2018 •
edited by iccub
Loading

It'd be nice to offer more url schemes than the only one we support right now (open-url) which requires that the input be a URL.

Possible additions:

  • brave://search?q=<search-query>: Allow a user to pass in any string that would search with whatever search engine the user is currently using
  • brave://bookmark?url=<url>: Allow the user to bookmark a URL from outside the app

In addition to the url scheme we have: brave://open-url?url=<url> which will fail if a non-url string is passed through.
@kylehickinson kylehickinson changed the title Add more brave:// URL schemes to allow more actions Add more brave:// URL scheme actions Dec 14, 2018
@jhreis jhreis added QA/Yes release-notes/include blocked: needs info Needs further information before work can commence labels Mar 18, 2019
@jhreis
Copy link
Contributor

jhreis commented Mar 21, 2019 •
edited
Loading

We need to have some discussion to identify what specifically is wanted here. Blocking for now.

Those two above would be great. We will need some mechanism for notification regarding the bookmarking, but initial backend logic can be built first.

@jhreis jhreis removed the blocked: needs info Needs further information before work can commence label Apr 1, 2019
@KacperWybranski KacperWybranski mentioned this issue Apr 27, 2021
Merged
7 tasks
@iccub iccub added this to the 1.28 milestone Jun 9, 2021
@iccub iccub closed this as completed in 37695cd Jun 21, 2021
@iccub iccub mentioned this issue Jun 21, 2021
Open
@iccub
Copy link
Contributor

iccub commented Jun 21, 2021

Search action implemented by an external contributor, added followup ticket for the bookmark action #3825

@iccub iccub added blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue security labels Jun 23, 2021
@iccub iccub modified the milestones: 1.28, 1.29 Jun 23, 2021
@iccub
Copy link
Contributor

iccub commented Jun 23, 2021

Moved to 1.29,
late security review requested here https://github.com/brave/security/issues/492

cc @jumde

iccub added a commit that referenced this issue Jun 23, 2021
@iccub
Revert "Fix #627 Add brave://search URL scheme (#3582)"
8aa171f 
This reverts commit 37695cd.
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.29(21.7.16.17)

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.29(21.7.16.17)

Verification passed on iPad Pro with iOS 14.6 running 1.29(21.7.16.17)

@kjozwiak kjozwiak mentioned this issue Aug 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue enhancement good first issue QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Projects
None yet
Milestone
1.29
Development

No branches or pull requests
4 participants
@kylehickinson @jhreis @iccub @srirambv