Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Leaving URL bar overlay mode with the cancel button after hiding the keyboard does not restore the toolbar/leaves gap on NTP #6259

Closed
kylehickinson opened this issue Oct 26, 2022 · 1 comment · Fixed by #6262
Closed

Leaving URL bar overlay mode with the cancel button after hiding the keyboard does not restore the toolbar/leaves gap on NTP #6259

kylehickinson opened this issue Oct 26, 2022 · 1 comment · Fixed by #6262
Assignees
@kylehickinson
Labels
bug Epic: UI/UX QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.45

Comments

@kylehickinson
Copy link
Collaborator

Steps to Reproduce

  1. Enable bottom bar if not on
  2. Focus the URL bar
  3. Dismiss the keyboard by swiping downwards from above the keyboard to over the keyboard
  4. Tap the "Cancel" button next to the URL bar

Actual result: Toolbar is not visible, if on NTP there will be a gap
Expected result: Toolbar should be restored, NTP should have correct size
Reproduces how often: Always
Brave Version: 1.44

Screen.Recording.2022-10-26.at.3.11.52.PM.mov

Ref #6235
@kylehickinson kylehickinson self-assigned this Oct 26, 2022
kylehickinson added a commit that referenced this issue Oct 26, 2022
@kylehickinson
Fix #6259: Update bottom bar view constraints when leaving overlay mode
98c50c3
@kylehickinson kylehickinson mentioned this issue Oct 26, 2022
Merged
11 tasks
kylehickinson added a commit that referenced this issue Oct 27, 2022
@kylehickinson
Fix #6259: Update bottom bar view constraints when leaving overlay mo…
20ffcfc 
…de (#6262)
@iccub iccub added this to the 1.45 milestone Oct 31, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 3, 2022 •
edited
Loading

Verified on 1.45 (22.11.3.16) using the following device(s):

iPhone 12 - iOS 16.1
iPhone XR - iOS 15.x
iPhone X - iOS 14.x

Test Plan: #6259 (comment)

  • Verified hiding keyboard by swiping down and tapping the cancel button does not leave gap on NTP
  • Verified does not leave gap on webpage
NTP - iOS 16.xWebpage - iOS 14.x
RPReplay_Final1667494016.MP4
RPReplay_Final1667494249.MP4

@srirambv srirambv mentioned this issue Nov 15, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: UI/UX QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.45
Development

Successfully merging a pull request may close this issue.

Fix #6259: Update bottom bar view constraints when leaving overlay mode brave/brave-ios
3 participants
@kylehickinson @iccub @Uni-verse