Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Full Screen - Popover Callout Optimizations #5981

Closed
iccub opened this issue Sep 7, 2022 · 2 comments · Fixed by #7292
Closed

Full Screen - Popover Callout Optimizations #5981

iccub opened this issue Sep 7, 2022 · 2 comments · Fixed by #7292

Comments

@iccub
Copy link
Contributor

iccub commented Sep 7, 2022

  • Callout Manager should be moved to Onboarding target and the responsibility of logic should be evaluated outside Browser.

  • Present Callout logic should be unified so when the presentation logic is changed or any alteration to callouts (edits / remove / add) can be easily done

  • Onboarding popups should be dismissible by tapping outside of them When the popup shows up, when you tap outside of it the view should be dismissed

@soner-yuksel soner-yuksel self-assigned this Apr 19, 2023
@soner-yuksel soner-yuksel added this to the 1.51 milestone Apr 19, 2023
@soner-yuksel soner-yuksel changed the title Onboarding popups should be dismissible by tapping outside of them Full Screen - Popover Callout Optimizations Apr 19, 2023
@soner-yuksel
Copy link
Contributor

@iccub alterations is made to this ticket so while editing for 1 click dismissal, some useful changes can be made to callout logic and target ownership of logic.

@Uni-verse
Copy link
Contributor

Uni-verse commented May 15, 2023

Verified on iPhone X running iOS 16.3.1 using version 1.51 (23.5.15.14)

Using Test Plan in #7292 (comment)

  • Ensured Link Subscription, Default Browser, VPN and Bottom Bar callouts are presented and user is able to dismiss by tapping outside of the pop-up
Link Subscription Default Browser Bottom Bar VPN
IMG_3205 IMG_3207 IMG_3204 IMG_3208

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants