Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[hackerone] security tokens issue #5859

Closed
diracdeltas opened this issue Aug 15, 2022 · 3 comments · Fixed by #5869
Closed

[hackerone] security tokens issue #5859

diracdeltas opened this issue Aug 15, 2022 · 3 comments · Fixed by #5869
Assignees
Milestone

Comments

@diracdeltas
Copy link
Member

https://hackerone.com/reports/1668723

credit: nishimunea

@diracdeltas diracdeltas added security priority/P1 A very extremely bad problem. We might push a hotfix for it. sec-high labels Aug 15, 2022
@iccub iccub added this to the 1.42 milestone Aug 15, 2022
@iccub iccub closed this as completed in b4d1040 Aug 16, 2022
iccub pushed a commit that referenced this issue Aug 16, 2022
Refactor scripts for security reasons
@kjozwiak
Copy link
Member

kjozwiak commented Aug 17, 2022

@kjozwiak
Copy link
Member

kjozwiak commented Aug 17, 2022

@Uni-verse @srirambv I don't have a iOS 14 device anymore but we should check the above with iOS 14 just to make sure it's working/fixed as well as it's a P1 security issue. Can add the verification notes into https://github.com/brave/internal/issues/896 and mentioned that it passed in this issue 👍

@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.42 (22.8.15.22). Verification notes can be found here https://github.com/brave/internal/issues/896#issuecomment-1217491963

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants