Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Terminating the app throws fatal error from brave-core end. #5804

Closed
iccub opened this issue Aug 8, 2022 · 2 comments · Fixed by brave/brave-core#14560 or #5821
Closed

Terminating the app throws fatal error from brave-core end. #5804

iccub opened this issue Aug 8, 2022 · 2 comments · Fixed by brave/brave-core#14560 or #5821
Assignees
@Brandon-T
Labels
bug crash QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression
Milestone
1.42

Comments

@iccub
Copy link
Contributor

iccub commented Aug 8, 2022

Description:

Steps to Reproduce

  1. Use a non debug build
  2. Kill the app from memory

Actual result:
Crash popup will show up

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@Brandon-T Brandon-T self-assigned this Aug 9, 2022
@Brandon-T Brandon-T added this to the 1.42 milestone Aug 9, 2022
This was referenced Aug 9, 2022
Merged
Merged
@iccub iccub reopened this Aug 10, 2022
@iccub
Copy link
Contributor Author

iccub commented Aug 10, 2022

Let's close since this can be tested on 1.42 builds.
For 1.43 we wait on the brave-core build to close related pull request

@iccub iccub closed this as completed Aug 10, 2022
Brandon-T added a commit that referenced this issue Aug 11, 2022
@Brandon-T
Fix #5804: Fixes crash when terminating Brave-Core (#5821)
c51b654 
Do not call brave-core's termination function.
@Uni-verse
Copy link
Contributor

Verified using 1.42 (22.8.10.15)

Test Devices:

iPhone XR iOS 15.5
iPad (7th Gen) iOS 15.5
iPhone X iOS 14.4.2

  • Confirmed removing the app from memory doesn't trigger error.
RPReplay_Final1660234938.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug crash QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression
Projects
None yet
Milestone
1.42
3 participants
@Brandon-T @iccub @Uni-verse