Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Hide recovery seed phrase when app is backgrounded #5744

Closed
StephenHeaps opened this issue Jul 26, 2022 · 1 comment · Fixed by #5755
Closed

Hide recovery seed phrase when app is backgrounded #5744

StephenHeaps opened this issue Jul 26, 2022 · 1 comment · Fixed by #5755
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Milestone
1.42

Comments

@StephenHeaps
Copy link
Contributor

Description:

When the application is backgrounded, the recovery seed phrase should be hidden so it's not visible in the app switcher.
@StephenHeaps StephenHeaps self-assigned this Jul 26, 2022
@StephenHeaps StephenHeaps mentioned this issue Jul 28, 2022
Merged
11 tasks
@StephenHeaps StephenHeaps added this to the 1.42 milestone Jul 28, 2022
StephenHeaps added a commit that referenced this issue Jul 29, 2022
@StephenHeaps
Fix #5744: Hide recovery phrase when app is backgrounded (#5755)
38ecb72 
Add new `CustomPrivacySensitiveModifier` SwiftUI view modifier that hides the content when in background or recording using `redacted(reason: .placeholder)`. Not using `.privacySensitive()` / `.redacted(reason: .privacy)` as they not working as expected due to `redactionReasons` not propagating through the environment in modals.
@srirambv
Copy link
Contributor

srirambv commented Aug 9, 2022

Verification passed on the following devices running 1.42 (22.8.8.19)

  • Verified steps from #5755
  • Verified recovery seed phrase is hidden when backgrounded
  • Verified for both Verify recovery phrase screen and Your recovery phrase screen
iPhone 7+ (iOS 14.8.1) iPhone XR (iOS 15.4.1) iPad Pro (iOS 15.6 Beta)

@srirambv srirambv mentioned this issue Aug 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.42
Development

Successfully merging a pull request may close this issue.

Fix #5744: Hide recovery phrase when app is backgrounded brave/brave-ios
3 participants
@diracdeltas @StephenHeaps @srirambv