Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add support for Dynamic Type on the URL bar & toolbar #5683

Closed
kylehickinson opened this issue Jul 13, 2022 · 1 comment · Fixed by #5684
Closed

Add support for Dynamic Type on the URL bar & toolbar #5683

kylehickinson opened this issue Jul 13, 2022 · 1 comment · Fixed by #5684

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Jul 13, 2022

Description:

This is an issue that outlines a small subset of the full dynamic type support issue (#1344)

This should add dynamic font + image sizes on the URL bar, tab bar and toolbar

Test Plan

  • Test that toolbar buttons scale at Large, XL and XXL and get no bigger after
  • Test landscape + iPad to ensure bottom toolbar buttons that end up in the top toolbar behave the same
  • Test various extra URL bar buttons: playlist, reader mode, wallet, rewards behave the same
  • Test that various onboarding popovers that highlight elements in the URL bar look correct
  • Test that URL bar text scales until Accessibility Large and no more after
  • Test that the collapsed URL bar does the same
  • Test that the tab titles in the tab bar scale until XXL and no further
@kylehickinson kylehickinson self-assigned this Jul 13, 2022
@kylehickinson kylehickinson added this to the 1.42 milestone Jul 15, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 10, 2022

Verified using 1.42 (22.8.8.19)

Test Devices:

iPhone XR iOS 15.5
iPad (7th Gen) iOS 15.5
iPhone X iOS 14.4.2

Toolbar buttons

  • Ensured toolbar buttons scale dynamics and get no bigger after XXL
  • Ensured button scale is limited to XXL in both orientations

Landscape + iPad (top toolbar buttons)

  • Ensured toolbar buttons in the top toolbar behave the same
  • Ensured toolbar buttons on ipad behave the same

Various extra URL bar buttons: playlist, reader mode, wallet, rewards behave the same

  • Confirmed URL bar buttons are working normally

Various onboarding popovers that highlight elements in the URL bar look correct

  • Confirmed onboarding popovers

Issue - default onboarding button text ui issue.

URL bar text scales until Accessibility Large and no more after

  • Confirmed URL text scales until Accessibility Large

Issue - text scales more than accessibility large

Collapased URL bar

  • Collapsed URL bar behaves the same way

Tab titles in the tab bar scale until XXL and no further

  • Confirmed tab bar scales until XXL
1 2
IMG_0503 IMG_0015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.