You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 10, 2024. It is now read-only.
If you switch to the same network multiple times (which will cause balance calls to execute) there is a chance for the balance calls to double-up as the assets for that network will be the same. The balances will then add up incorrectly.
Most likely there are race conditions between fetching balances and prices where userVisibleAssets is already set with some balances and thus its adding balances to a state that isn't currently 0.
The text was updated successfully, but these errors were encountered:
…5098)
* Fix race condition in `PortfolioStore`s update function which could cause us to double our balance if update is called repeatedly (changing networks, or choosing same network).
* Add `PortfolioStoreTests` for unit testing the `PortfolioStore`. Currently verifies `update()` will publish changes to it's various publishers correctly.
Verification PASSED on iPhone 10 running 15.4.1 using 1.37 (22.4.6.8)
Went through the STR/Cases outlined via #5098 (comment) and ensured that the current balance wasn't appearing as $0.00 or was exceeding what's actually present.
Example
Example
Verification PASSED on iPhone 6+ running 14.6 using 1.37 (22.4.6.8)
Went through the STR/Cases outlined via #5098 (comment) and ensured that the current balance wasn't appearing as $0.00 or was exceeding what's actually present.
If you switch to the same network multiple times (which will cause balance calls to execute) there is a chance for the balance calls to double-up as the assets for that network will be the same. The balances will then add up incorrectly.
Most likely there are race conditions between fetching balances and prices where
userVisibleAssets
is already set with some balances and thus its adding balances to a state that isn't currently 0.The text was updated successfully, but these errors were encountered: