Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Restore old tab tray animation #4841

Closed
kylehickinson opened this issue Jan 11, 2022 · 2 comments · Fixed by #4842
Closed

Restore old tab tray animation #4841

kylehickinson opened this issue Jan 11, 2022 · 2 comments · Fixed by #4842

Comments

@kylehickinson
Copy link
Collaborator

Description:

We recently refactored the tab tray and replaced the presentation animation with a standard sheet. Feedback suggests that users liked the old version better and so we should restore the transform-style animation

@iccub
Copy link
Contributor

iccub commented Jan 14, 2022

Copying over improvement suggestions from the pull request

Improvements that could happen: Instead of taking a screenshot of the NTP/web page we should use the actual BVC and do scale + anchorPoint animations so that we are safer from screenshot & final view not matching causing a slight mismatch.

@Uni-verse Uni-verse self-assigned this Jan 18, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 19, 2022

Verification PASSED on iPhone 12 Pro running iOS 15.1.1 using build version 1.35 (22.1.14.22)

  • Verified transform-style animation is applied to tab tray

Test Scenarios (for each device)

  • Access the tab tray as usual from the browser
  • Add new tabs until the number of tabs exceeds the on-screen space
  • Verify that tabs transform correctly even when the tab would be off-screen initially (and vice-versa tapping on a partially off-screen tab, or tapping done while selected tab is off-screen)
  • Verify private mode acts as normal
  • Verify removing all tabs acts as normal

IMG_2338

RPReplay_Final1642556890.MP4

Verification PASSED on iPhone X running iOS 14.4.2 using build version 1.35 (22.1.14.22)

IMG_2577

RPReplay_Final1642556630.MP4

Verification PASSED on iPad (7th Gen) running iPadOS 14.4.2 using build version 1.35 (22.1.14.22)

IMG_0099
IMG_0100
IMG_0101

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.