This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 440
Restore old tab tray animation #4841
Labels
Milestone
Comments
kylehickinson
added a commit
that referenced
this issue
Jan 11, 2022
7 tasks
iccub
pushed a commit
that referenced
this issue
Jan 14, 2022
Copying over improvement suggestions from the pull request Improvements that could happen: Instead of taking a screenshot of the NTP/web page we should use the actual BVC and do scale + anchorPoint animations so that we are safer from screenshot & final view not matching causing a slight mismatch. |
Verification PASSED on
Test Scenarios (for each device)
RPReplay_Final1642556890.MP4Verification PASSED on RPReplay_Final1642556630.MP4Verification PASSED on |
kylehickinson
added a commit
that referenced
this issue
Jan 20, 2022
7 tasks
kylehickinson
added a commit
that referenced
this issue
Jan 20, 2022
iccub
pushed a commit
that referenced
this issue
Jan 21, 2022
kylehickinson
added a commit
that referenced
this issue
Jan 24, 2022
Also fixes a potential crash if animation dismissal short-circuits
iccub
pushed a commit
that referenced
this issue
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Description:
We recently refactored the tab tray and replaced the presentation animation with a standard sheet. Feedback suggests that users liked the old version better and so we should restore the transform-style animation
The text was updated successfully, but these errors were encountered: