Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Bookmarks are sometimes not synced in their corresponding folders. #450

Closed
iccub opened this issue Nov 26, 2018 · 6 comments
Closed

Bookmarks are sometimes not synced in their corresponding folders. #450

iccub opened this issue Nov 26, 2018 · 6 comments
Assignees
@jhreis @iccub
Labels
bug release-notes/exclude release-notes/include

Comments

@iccub
Copy link
Contributor

iccub commented Nov 26, 2018

Sometimes when you quickly add folders and bookmarks, syncing them on other device result in bookmarks being outside of folders
@iccub iccub added the sync label Nov 26, 2018
@iccub
Copy link
Contributor Author

iccub commented Nov 26, 2018

Related https://github.com/brave/browser-ios/issues/1776

iccub added a commit to iccub/brave-ios that referenced this issue Dec 14, 2018
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
b2326ed 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 2, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
62109e3 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 8, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
71487bd 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 11, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
01c7d00 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 14, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
eb1b919 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 14, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
f85839a 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 16, 2019
@iccub
Revert "Fix brave#450, create resolved bookmarks from the oldest to n…
eae5676 
…ewest by syncTimestamp."

This reverts commit f85839a.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 16, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
05b6457 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 16, 2019
@iccub
Fix brave#450, create resolved bookmarks from the oldest to newest by…
7823272 
… syncTimestamp.
iccub added a commit to iccub/brave-ios that referenced this issue Jan 16, 2019
@iccub
Ref brave#450, create resolved bookmarks from the oldest to newest by…
341f445 
… syncTimestamp.
jhreis pushed a commit that referenced this issue Jan 16, 2019
@iccub
Ref #450, create resolved bookmarks from the oldest to newest by sync…
eb28250 
…Timestamp.
@jhreis jhreis self-assigned this Jan 25, 2019
@iccub iccub self-assigned this Jan 25, 2019
@jhreis jhreis closed this as completed in f8ff516 Jan 28, 2019
@iccub iccub added the QA/Yes label Feb 6, 2019
@srirambv srirambv added this to the 1.9 milestone Mar 14, 2019
This was referenced Mar 14, 2019
Closed
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 14, 2019 •
edited by kjozwiak
Loading

  • Verified passed with 1.9 (19.3.9.1) on iPad 5th Gen. Tried adding bookmarks and folders quickly. Also imported bookmarks/folders and verified they were all synced correctly.
  • Verified passed with 1.9 (19.3.9.1) on iPhone SE. All folders and bookmarks synced correctly.
  • Verified passed with 1.9 (19.3.9.1) on iPhone 8. All folders and bookmarks synced correctly.
  • Verification PASSED with 1.9 (19.3.27.19) on iPad Mini 4

@srirambv srirambv mentioned this issue Mar 18, 2019
Closed
@srirambv
Copy link
Contributor

Ran into #985 while verifying the issue when same bookmarks are added/deleted when syn chain is enabled

@srirambv
Copy link
Contributor

This needs to be verified again after #985 is fixed. Marking as 1.10 GH milestone so that it gets verified for the next build.

@srirambv srirambv modified the milestones: 1.9, 1.10 Mar 28, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jul 23, 2019 •
edited
Loading

Going to remove this from 1.10 as it doesn't seem like any work went into this one.

Ran into #985 while verifying the issue when same bookmarks are added/deleted when syn chain is enabled

Looks like #985 still hasn't been resolved. Sounds like we'll need to wait for #985 to be resolved before we start going through this one again. @michal, does the above sound right? If not, please move it back into 1.10 👍

@kjozwiak kjozwiak removed this from the 1.10 milestone Jul 23, 2019
@iccub
Copy link
Contributor Author

iccub commented Jul 23, 2019

@kjozwiak Sync is going to be reworked anyway so we can wait with it. It's ok to remove it from 1.10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhreis jhreis

@iccub iccub

Labels
bug release-notes/exclude release-notes/include
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kjozwiak @jhreis @iccub @srirambv @LaurenWags @btlechowski @GeetaSarvadnya