Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Updated onboarding - Sync and Rewards scheduled callouts. #4376

Closed
2 tasks
iccub opened this issue Oct 20, 2021 · 3 comments · Fixed by #4508
Closed
2 tasks

Updated onboarding - Sync and Rewards scheduled callouts. #4376

iccub opened this issue Oct 20, 2021 · 3 comments · Fixed by #4508
Assignees
@Brandon-T @soner-yuksel
Labels
enhancement Epic: Retention QA Pass - iPad QA Pass - iPhone QA/Yes
Milestone
1.33

Comments

@iccub
Copy link
Contributor

iccub commented Oct 20, 2021

See Mobile Onboarding 2021 Revision doc in shared drive.
Day 4: Sync other devices and Day 7: Rewards sections

  • Add sync callout
  • Add Rewards callout
@iccub iccub added this to the 1.32.5 milestone Oct 20, 2021
@Brandon-T Brandon-T mentioned this issue Nov 15, 2021
Merged
7 tasks
@Brandon-T Brandon-T linked a pull request Nov 15, 2021 that will close this issue
Update onboarding flow and UI #4508
Merged
7 tasks
iccub pushed a commit that referenced this issue Nov 19, 2021
@Brandon-T
Fix #4372, fix #4373, fix #4374, fix #4376, fix #4378, fix #4450: New…
baf7293 
… onboarding (#4508)
@iccub iccub modified the milestones: 1.32.5, 1.33 Dec 1, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 9, 2021 •
edited
Loading

  • Callouts should be shown only for the new users, not for the existing users, mentioned in the spec (table at the end) and confirmed with @soner-yuksel

Callout days for different popups

VPN callout will happen on OR after 4days
Sync callout will happen on OR after 6days
Rewards callout will happen on OR after 8days
Default browser callout will happen on OR after 10days

Test plan:

Callout Orders for New user_Normal Browsing mode

Case 1: Order of popovers when if no of days >=4days

(4 days passed 1 callout conditions is satisfied)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Kill the app from memory
  4. Set the device date ahead by 4+ days (In my case I have set it to 15th Dec)
  5. Relaunch the app and confirm VPN callout is shown to the user
  6. Kill the app from memory and relaunch the app
  7. Confirm no callout will happen
  8. Repeat step 6 and confirm no callout will happen
Case 2: Order of popovers when if no of days =6days

(6 days passed and 2 callout conditions are satisfied)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro message
  3. Kill the app from memory
  4. Set the device date ahead by 6 days
  5. Relaunch the app and confirm VPN callout is shown to the user
  6. Kill the app from memory
  7. Relaunch the app and confirm Sync callout is shown to the user
Case 3: Order of popovers when if no of days >=7days

(7 days passed and 2 callout conditions are satisfied)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro message
  3. Kill the app from memory
  4. Set the device date ahead by 6+ days (In my case I have set it to 17th Dec)
  5. Relaunch the app and confirm VPN callout is shown to the user
  6. Kill the app from memory and relaunch
  7. Sync callout should happen
  8. Kill the app from memory and relaunch
  9. No other callout will be shown
  10. Repeat step 8 again and confirm no callouts will happen
Case 4: Order of popovers when if no of days >=9days

(9 days passed and 3 callout conditions are satisfied)

  1. Launch browser, skip the onboarding flow, and dismiss NTP intro messages
  2. Kill the app from memory
  3. Set the device date ahead by 9 days (In my case I have set it to 19th Dec)
  4. Launch browser
  5. VPN call should happen in 1st launch
  6. Kill the app from memory
  7. Rewards callout should happen
  8. Kill the app from memory
  9. Sync callout should happen
Case 5: Order of popovers when if no of days >=10days

(10 days passed and all the 4 callout conditions are satisfied)

  1. Launch browser, skip onboarding and dismiss NTP intro messages
  2. Kill the app from memory
  3. Set the device date ahead by 12 days (in my case I have set it to 22nd Dec)
  4. Launch browser
  5. VPN callout should happen (as per the spec VPN callout should happen 1st when all the conditions are satisfied)
  6. Kill the app from memory
  7. Launch browser
  8. Default browser callout should happen (as it has got precedence over the brave rewards)
  9. Kill the app from memory
  10. Launch browser
  11. Rewards callout should happen (If rewards are available for the region) as It has got precedence over sync callout
  12. Kill the app from memory
  13. Launch browser
  14. Sync callout should happen
Case 6: Order of popovers when sync is enabled and if no of days >=6days

(6 days passed 2 callout conditions are satisfied (VPN and Sync). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 6+ days (In my case I have set it to 17th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Sync callout should not happen as sync is already enabled
  11. Repeat steps 8 and 9 and ensure no callouts will happen
Case 7: Order of popovers when sync is enabled and if no of days >=8days

(8 days passed 3 callout conditions are satisfied (VPN, Sync, and Rewards). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 8+ days (In my case I have set it to 19th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Rewards callout should happen
  11. Repeat steps 8 and 9 and confirm sync callout will not happen as it's enabled (no callouts will happen in this step)
Case 8: Order of popovers when sync is enabled and if no of days >=10days

(10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 10+ days (In my case I have set it to 22nd Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Rewards callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (sync callout will not happen as sync is already enabled)
Case 9: Order of popovers when Rewards is enabled and if no of days >=8days

(8 days passed 3 callout conditions are satisfied (VPN, Sync, and Rewards). But Rewards callout should not happen if Rewards is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the Rewards (Tap on BR panel in NTP and click on Start in Rewards popup)
  4. Kill the app from memory
  5. Set the device date ahead by 8+ days (In my case I have set it to 19th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Sync callout should happen
  11. Repeat steps 8 and 9
  12. No callouts should happen
Case 10: Order of popovers when Rewards is enabled and if no of days >=10days

(10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But rewards callout should not happen if Rewards is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the Rewards (Tap on BR panel in NTP and click on Start in Rewards popup)
  4. Kill the app from memory
  5. Set the device date ahead by 10+ days (In my case I have set it to 22nd Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Sync callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (rewards callout will not happen as rewards is already enabled)

Callout Orders for New user_Private Browsing Only mode

Prerequisites: After installing brave, skip the onboarding flow and dismiss the NTP intro messages and then open Settings>Brave Shields & Privacy>Enable Private Browsing Only switch for each case.

Case 1: Order of popovers when if no of days >=4days

(4 days passed 1 callout conditions is satisfied)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Kill the app from memory
  4. Set the device date ahead by 4+ days (In my case I have set it to 15th Dec)
  5. Relaunch the app and confirm VPN callout is shown to the user
  6. Kill the app from memory and relaunch the app
  7. Confirm no callout will happen
  8. Repeat step 6 and confirm no callout will happen
Case 2: Order of popovers when if no of days =6days

(6 days passed and 2 callout conditions are satisfied)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro message
  3. Kill the app from memory
  4. Set the device date ahead by 6 days
  5. Relaunch the app and confirm VPN callout is shown to the user
  6. Kill the app from memory
  7. Relaunch the app and confirm Sync callout is shown to the user
Step 5 Step 7
Case 3: Order of popovers when if no of days >=7days

(7 days passed and 2 callout conditions are satisfied)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro message
  3. Kill the app from memory
  4. Set the device date ahead by 6+ days (In my case I have set it to 17th Dec)
  5. Relaunch the app and confirm VPN callout is shown to the user
  6. Kill the app from memory and relaunch
  7. Sync callout should happen
  8. Kill the app from memory and relaunch
  9. No other callout will be shown
  10. Repeat step 8 again and confirm no callouts will happen
Step 7 Step 5
IMG_0202
Case 4: Order of popovers when if no of days >=9days

(9 days passed and 3 callout conditions are satisfied)

  1. Launch browser, skip the onboarding flow, and dismiss NTP intro messages
  2. Kill the app from memory
  3. Set the device date ahead by 9 days (In my case I have set it to 19th Dec)
  4. Launch browser
  5. VPN call should happen in 1st launch
  6. Kill the app from memory
  7. Rewards callout should happen
  8. Kill the app from memory
  9. Sync callout should happen
Step 7 Step 9 Step 5
IMG_0200 IMG_0201
Case 5: Order of popovers when if no of days >=10days

(10 days passed and all the 4 callout conditions are satisfied)

  1. Launch browser, skip onboarding and dismiss NTP intro messages
  2. Kill the app from memory
  3. Set the device date ahead by 12 days (in my case I have set it to 22nd Dec)
  4. Launch browser
  5. VPN callout should happen (as per the spec VPN callout should happen 1st when all the conditions are satisfied)
  6. Kill the app from memory
  7. Launch browser
  8. Default browser callout should happen (as it has got precedence over the brave rewards)
  9. Kill the app from memory
  10. Launch browser
  11. Rewards callout should happen (If rewards are available for the region) as It has got precedence over sync callout
  12. Kill the app from memory
  13. Launch browser
  14. Sync callout should happen
step 8 step 11 step 14 Step 5
IMG_0193 IMG_0194 IMG_0195
Case 6: Order of popovers when sync is enabled and if no of days >=6days

(6 days passed 2 callout conditions are satisfied (VPN and Sync). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 6+ days (In my case I have set it to 17th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Sync callout should not happen as sync is already enabled
  11. Repeat steps 8 and 9 and ensure no callouts will happen
Case 7: Order of popovers when sync is enabled and if no of days >=8days

(8 days passed 3 callout conditions are satisfied (VPN, Sync, and Rewards). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 8+ days (In my case I have set it to 19th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Rewards callout should happen
  11. Repeat steps 8 and 9 and confirm sync callout will not happen as it's enabled (no callouts will happen in this step)
Case 8: Order of popovers when sync is enabled and if no of days >=10days

(10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 10+ days (In my case I have set it to 22nd Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Rewards callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (sync callout will not happen as sync is already enabled)
Case 9: Order of popovers when Rewards is enabled and if no of days >=8days

(8 days passed 3 callout conditions are satisfied (VPN, Sync, and Rewards). But Rewards callout should not happen if Rewards is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the Rewards (Tap on BR panel in NTP and click on Start in Rewards popup)
  4. Kill the app from memory
  5. Set the device date ahead by 8+ days (In my case I have set it to 19th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Sync callout should happen
  11. Repeat steps 8 and 9
  12. No callouts should happen
Case 10: Order of popovers when Rewards is enabled and if no of days >=10days

(10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But rewards callout should not happen if Rewards is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the Rewards (Tap on BR panel in NTP and click on Start in Rewards popup)
  4. Kill the app from memory
  5. Set the device date ahead by 10+ days (In my case I have set it to 22nd Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Sync callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (rewards callout will not happen as rewards is already enabled)

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Dec 10, 2021
Closed
1 task
@stephendonner
Copy link
Contributor

stephendonner commented Dec 12, 2021 •
edited
Loading

Verified PASSED using Brave 1.33 (21.12.10.20) on an iPhone 6s (iOS 14.4.2).

Ran through Case 5: Order of popovers when no. of days 10 >.

NOTE:

Filed the following two issues for the callout-cards' incorrect ordering:

@LaurenWags
Copy link
Member

LaurenWags commented Dec 13, 2021 •
edited
Loading

Verified on iPad mini with iOS 15 running 1.33 (21.12.13.3)

Case 5: Order of popovers when if no of days =10days

(10 days passed and all the 4 callout conditions are satisfied)

  1. Launch browser, skip onboarding and dismiss NTP intro messages
  2. Kill the app from memory
  3. Set the device date ahead by 10 days (in my case I have set it to 23rd Dec)
  4. Launch browser
  5. VPN callout should happen (as per the spec VPN callout should happen 1st when all the conditions are satisfied)
  6. Kill the app from memory
  7. Launch browser
  8. Default browser callout should happen (as it has got precedence over the brave rewards)
  9. Kill the app from memory
  10. Launch browser
  11. Rewards callout should happen (If rewards are available for the region) as It has got precedence over sync callout
  12. Kill the app from memory
  13. Launch browser
  14. Sync callout should happen
Step 5 Step 8 Step 11 Step 14
IMG_0176 IMG_0177 IMG_0178 IMG_0179
Case 5: Order of popovers when if no of days >10days

(more than 10 days passed and all the 4 callout conditions are satisfied, although out of order - see logged issue #4719)

  1. Launch browser, skip onboarding and dismiss NTP intro messages
  2. Kill the app from memory
  3. Set the device date ahead by 12 days (in my case I have set it to 25th Dec)
  4. Launch browser
  5. VPN callout should happen (as per the spec VPN callout should happen 1st when all the conditions are satisfied)
  6. Kill the app from memory
  7. Launch browser
  8. Default browser callout should happen (as it has got precedence over the brave rewards)
  9. Kill the app from memory
  10. Launch browser
  11. Rewards callout should happen (If rewards are available for the region) as It has got precedence over sync callout
  12. Kill the app from memory
  13. Launch browser
  14. Sync callout should happen
Step 5 Step 8 Step 11 Step 14
IMG_0171 IMG_0172 IMG_0173 IMG_0174

Note, as mentioned, steps 5 and 8 results are switched. Known issue.

Case 8: Order of popovers when sync is enabled and if no of days =10days

(10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But sync callout should not happen if Sync is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 10 days (In my case I have set it to 23rd Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Rewards callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (sync callout will not happen as sync is already enabled)
Step 7 Step 10 Step 12
IMG_0180 IMG_0181 IMG_0182
Case 8: Order of popovers when sync is enabled and if no of days >10days

(>10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But sync callout should not happen if Sync is enabled. First 2 call outs are out of order - see logged issue #4719)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the standalone sync
  4. Kill the app from memory
  5. Set the device date ahead by 12 days (In my case I have set it to 25th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Rewards callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (sync callout will not happen as sync is already enabled)
Step 7 Step 10 Step 12
IMG_0183 IMG_0184 IMG_0185

Note, as mentioned, steps 7 and 10 results are switched. Known issue.

Case 10: Order of popovers when Rewards is enabled and if no of days =10days

(10 days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But rewards callout should not happen if Rewards is enabled)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the Rewards (Tap on BR panel in NTP and click on Start in Rewards popup)
  4. Kill the app from memory
  5. Set the device date ahead by 10 days (In my case I have set it to 23rd Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Sync callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (rewards callout will not happen as rewards is already enabled)
Step 7 Step 10 Step 12
IMG_0186 IMG_0187 IMG_0188
Case 10: Order of popovers when Rewards is enabled and if no of days >10days

(10+ days passed all the 4 callout conditions are satisfied (VPN, Sync, Rewards, and Default browser). But rewards callout should not happen if Rewards is enabled. First 2 call outs are out of order - see logged issue #4719)

  1. Clean profile 1.33
  2. Skip the onboarding flow and dismiss the NTP intro messages
  3. Enable the Rewards (Tap on BR panel in NTP and click on Start in Rewards popup)
  4. Kill the app from memory
  5. Set the device date ahead by 12 days (In my case I have set it to 25th Dec)
  6. Relaunch the app
  7. VPN callout should happen
  8. Kill the app from memory
  9. Relaunch the app
  10. Default browser callout should happen
  11. Repeat steps 8 and 9
  12. Sync callout should happen
  13. Repeat steps 8 and 9
  14. No callouts should happen (rewards callout will not happen as rewards is already enabled)
Step 7 Step 10 Step 12
IMG_0189 IMG_0190 IMG_0191

Note, as mentioned, steps 7 and 10 results are switched. Known issue.

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

@soner-yuksel soner-yuksel

Labels
enhancement Epic: Retention QA Pass - iPad QA Pass - iPhone QA/Yes
Projects
None yet
Milestone
1.33
Development

Successfully merging a pull request may close this issue.

Update onboarding flow and UI brave/brave-ios
6 participants
@stephendonner @Brandon-T @soner-yuksel @iccub @LaurenWags @GeetaSarvadnya