Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Playlist - Replace Toast with URL Bar Icon + Add Playlist Menu Button #3976

Closed
Brandon-T opened this issue Jul 28, 2021 · 1 comment · Fixed by #3977
Closed

Playlist - Replace Toast with URL Bar Icon + Add Playlist Menu Button #3976

Brandon-T opened this issue Jul 28, 2021 · 1 comment · Fixed by #3977
Assignees
@Brandon-T
Labels
enhancement Epic: Playlist feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.31

Comments

@Brandon-T
Copy link
Collaborator

Feature Overview

  • Add Playlist URL Bar Icon
  • Add Playlist Menu Button & Icon

Design

image

Implementation Details

  • Remove Toast
  • Playlist URL Bar Icon has to be associated with a tab so when switching tabs, the URL bar is updated according to the tab being viewed.
@Brandon-T Brandon-T mentioned this issue Jul 28, 2021
Merged
7 tasks
@iccub iccub mentioned this issue Aug 23, 2021
Closed
@iccub iccub added this to the 1.31 milestone Aug 23, 2021
iccub pushed a commit that referenced this issue Aug 25, 2021
@Brandon-T
Fix #3976: Replace Toast with Playlist URL Bar Icon + Add Playlist Me…
998bb96 
…nu Item (#3977)
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.31(21.9.14.15)

  • Verified playlist toast is now replaced with a URL bar button that shows up when a video page is loaded
  • Verified playlist menu notification also shows up when a video page is loaded
  • Verified when the video is added to playlist via URL bar button, menu notification is auto-removed
  • Verified after adding video to playlist, URL bar playlist button changes from Add to Added
  • Verified click on playlist added button, shows flyout to open playlist or remove
  • Verified removing a video from playlist via the URL button changes it back to Add to playlist button
  • Verified steps from #3977
Add Button & Menu notification Added to playlist
image image

Verification passed on iPhone 7+ with iOS 14.8 running 1.31(21.9.14.15)

  • Verified playlist toast is now replaced with a URL bar button that shows up when a video page is loaded
  • Verified playlist menu notification also shows up when a video page is loaded
  • Verified when the video is added to playlist via URL bar button, menu notification is auto-removed
  • Verified after adding video to playlist, URL bar playlist button changes from Add to Added
  • Verified click on playlist added button, shows flyout to open playlist or remove
  • Verified removing a video from playlist via the URL button changes it back to Add to playlist button
  • Verified steps from #3977
Add Button & Menu notification Added to playlist
image image

Verification passed on iPad Pro with iOS 15 running 1.31(21.9.14.15)

  • Verified playlist toast is now replaced with a URL bar button that shows up when a video page is loaded
  • Verified playlist menu notification also shows up when a video page is loaded
  • Verified when the video is added to playlist via URL bar button, menu notification is auto-removed
  • Verified after adding video to playlist, URL bar playlist button changes from Add to Added
  • Verified click on playlist added button, shows flyout to open playlist or remove
  • Verified removing a video from playlist via the URL button changes it back to Add to playlist button
  • Verified steps from #3977
Add Button & Menu notification Added to playlist
image image

@srirambv srirambv mentioned this issue Sep 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
enhancement Epic: Playlist feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.31
Development

Successfully merging a pull request may close this issue.

Fix #3976: Replace Toast with Playlist URL Bar Icon + Add Playlist Menu Item brave/brave-ios
3 participants
@Brandon-T @iccub @srirambv