Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Browser crash when favourite is dragged beyond favourites list #3879

Closed
srirambv opened this issue Jul 5, 2021 · 2 comments · Fixed by #3881
Closed

Browser crash when favourite is dragged beyond favourites list #3879

srirambv opened this issue Jul 5, 2021 · 2 comments · Fixed by #3881
Assignees
@iccub
Labels
bug crash QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.28

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2021

Description:

Browser crash when favourite is dragged beyond favourites list

Steps to Reproduce

  1. Clean install 1.27.1/1.28
  2. Tap on URL bar
  3. Long press and drag a favourite beyond the favourites section, browser crashes

Actual result:

Favourites.drag.crash.MP4

Expected result:
No crash

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.27.1/1.28

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @iccub issue started with 1.27 with new search overlay
@srirambv srirambv added this to the 1.28 milestone Jul 5, 2021
@srirambv srirambv mentioned this issue Jul 5, 2021
Closed
@iccub iccub self-assigned this Jul 5, 2021
iccub added a commit that referenced this issue Jul 5, 2021
@iccub
Fix #3879: Allow reordering of favorites only within their section.
6eef707
@iccub iccub mentioned this issue Jul 5, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Jul 5, 2021
@iccub
Fix #3879: Allow reordering of favorites only within their section. (#…
45c1c7e 
…3881)
iccub added a commit that referenced this issue Jul 5, 2021
@iccub
Fix #3879: Allow reordering of favorites only within their section. (#…
afcd28a 
…3881)
@srirambv srirambv mentioned this issue Jul 6, 2021
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Jul 6, 2021

Blocked on #3888

@srirambv
Copy link
Contributor Author

srirambv commented Jul 8, 2021

Verification passed on iPhone XR with iOS 13.5 running 1.28(21.7.6.16)

  • Verified no browser crash when favourite is dragged beyond favourite's section

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.28(21.7.6.16)

  • Verified no browser crash when favourite is dragged beyond favourite's section

Verification passed on iPad Pro with iOS 14.6 running 1.28(21.7.6.16)

  • Verified no browser crash when favourite is dragged beyond favourite's section

@srirambv srirambv mentioned this issue Jul 12, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug crash QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.28
Development

Successfully merging a pull request may close this issue.

Fix #3879: Allow reordering of favorites only within their section. brave/brave-ios
2 participants
@iccub @srirambv