Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Brave News: Display Ads #3872

Closed
kylehickinson opened this issue Jun 30, 2021 · 1 comment · Fixed by #3897
Closed

Brave News: Display Ads #3872

kylehickinson opened this issue Jun 30, 2021 · 1 comment · Fixed by #3897
Assignees
@kylehickinson
Labels
enhancement Epic: Ads Epic: Brave News QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.30

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Jun 30, 2021 •
edited
Loading

Spec: Display Ads for Brave News

  • Adds a new Brave Ad card to the sequence in Brave News
  • Opting into Brave News should initialize the ads service
  • Disabling Brave Rewards should only shutdown the ads service if Brave News is disabled
  • Updates Brave News sequence order (new pattern in spec)
@kylehickinson kylehickinson self-assigned this Jun 30, 2021
@iccub iccub added this to the 1.30 milestone Jul 7, 2021
kylehickinson added a commit that referenced this issue Jul 7, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads
5aa0bc4
@kylehickinson kylehickinson mentioned this issue Jul 7, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jul 14, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads
cb91fb7
kylehickinson added a commit that referenced this issue Aug 4, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads
80a5717
kylehickinson added a commit that referenced this issue Aug 4, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads
c1ab25a
kylehickinson added a commit that referenced this issue Aug 6, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads
61f681e
kylehickinson added a commit that referenced this issue Aug 9, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads
1b65b81
kylehickinson added a commit that referenced this issue Aug 9, 2021
@kylehickinson
Fix #3872: Adds Brave News Display Ads (#3897)
2c055d2 
Also bumps the brave-core build to 1.28.104
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.30(21.8.9.17)

  • Verified inline ads are shown when Brave News is enabled
  • Verified inline ads show even without having to enable rewards
  • Verified when Brave News is enabled ads library initializes
Logs 
10:36:30.306806-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for architecture segment
10:36:30.306946-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for arts & entertainment segment
10:36:30.307034-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for automotive segment
10:36:30.307328-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for business segment
10:36:30.307468-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for careers segment
10:36:30.309621-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for cell phones segment
10:36:30.309767-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for drugs segment
10:36:30.309863-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for education segment
10:36:30.310050-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for family & parenting segment
10:36:30.310138-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for fashion segment
10:36:30.310225-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for folklore segment
10:36:30.310312-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for food & drink segment
10:36:30.310385-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for health & fitness segment
10:36:30.310477-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for history segment
10:36:30.310600-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for hobbies & interests segment
10:36:30.310692-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for home segment
10:36:30.310790-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for law segment
10:36:30.315138-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for military segment
10:36:30.315207-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for personal finance segment
10:36:30.315237-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for pets segment
10:36:30.315265-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for politics segment
10:36:30.315296-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for real estate segment
10:36:30.315504-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for religion segment
10:36:30.315584-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for science segment
10:36:30.315648-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for society segment
10:36:30.315726-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for sports segment
10:36:30.315797-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for technology & computing segment
10:36:30.315872-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for travel segment
10:36:30.315937-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for weather segment
10:36:30.316191-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_processor.cc:52] > Epsilon greedy bandit arm was added for crypto segment
10:36:30.316258-0400	Client	[Info] [BraveCore] [epsilon_greedy_bandit_processor.cc:125] > Successfully initialized epsilon greedy bandit arms
10:36:30.316329-0400	Client	[Info] [BraveCore] [ads_impl.cc:102] > Initializing ads
10:36:30.326190-0400	Client	[Info] [BraveCore] [database_migration.cc:48] > Migrated database from version 0 to version 15
10:36:30.346565-0400	Client	[Debug] [BraveCore] [legacy_conversion_migration.cc:128] > Loading conversion state
10:36:30.347883-0400	Client	[Debug] [BraveCore] [legacy_conversion_migration.cc:134] > Successfully migrated conversion state
10:36:30.348119-0400	Client	[Debug] [BraveCore] [client.cc:547] > Loading client state
10:36:30.348773-0400	Client	[Debug] [BraveCore] [client.cc:556] > Client state does not exist, creating default state
10:36:30.350667-0400	Client	[Debug] [BraveCore] [confirmations_state.cc:69] > Loading confirmations state
10:36:30.351769-0400	Client	[Debug] [BraveCore] [confirmations_state.cc:75] > Confirmations state does not exist, creating default state
10:36:30.352420-0400	Client	[Debug] [BraveCore] [ad_notifications.cc:399] > Loading ad notifications state
10:36:30.353418-0400	Client	[Debug] [BraveCore] [ad_notifications.cc:408] > Ad notifications state does not exist, creating default state
10:36:30.369668-0400	Client	[Info] [BraveCore] [ads_impl.cc:603] > Successfully initialized ads
10:36:30.369735-0400	Client	[Info] [BraveCore] [brave_ads.mm:803] > Registering Brave Ads Resources Installer (en) with id ocilmpijebaopmdifcomolmpigakocmo
10:36:30.369820-0400	Client	[Info] [BraveCore] [brave_ads.mm:805] > Notifying ads resource observers
10:36:30.369885-0400	Client	[Info] [BraveCore] [brave_ads.mm:939] > Downloading iso_639_1_en ads resource manifest
10:36:30.373137-0400	Client	[Info] [BraveCore] [brave_ads.mm:841] > Registering Brave Ads Resources Installer (US) with id iblokdlgekdjophgeonmanpnjihcjkjj
10:36:30.373214-0400	Client	[Info] [BraveCore] [brave_ads.mm:843] > Notifying ads resource observers
10:36:30.373287-0400	Client	[Info] [BraveCore] [brave_ads.mm:939] > Downloading iso_3166_1_us ads resource manifest
10:36:30.381966-0400	Client	[Info] [BraveCore] [subdivision_targeting.cc:104] > Ads subdivision targeting is enabled for
10:36:30.382671-0400	Client	[Info] [BraveCore] [ad_server.cc:64] > Get catalog
10:36:30.383373-0400	Client	[Debug] [BraveCore] [ad_server.cc:65] > GET /v8/catalog
10:36:30.383493-0400	Client	[Debug] [BraveCore] [ad_server.cc:71] > URL Request:
  URL: https://ads-static.brave.com/v8/catalog
  Method: GET
10:36:30.384679-0400	Client	[Info] [BraveCore] [features.cc:41] > No active studies
10:36:30.384859-0400	Client	[Info] [BraveCore] [features.cc:50] > Text classification feature is enabled
10:36:30.384943-0400	Client	[Info] [BraveCore] [features.cc:53] > Epsilon greedy bandit feature is disabled
10:36:30.385190-0400	Client	[Info] [BraveCore] [features.cc:56] > Purchase intent feature is enabled
10:36:30.385540-0400	Client	[Info] [BraveCore] [features.cc:59] > Ad rewards feature is enabled
10:36:30.385734-0400	Client	[Info] [BraveCore] [features.cc:62] > Ad serving feature is enabled
10:36:30.385982-0400	Client	[Info] [BraveCore] [features.cc:65] > User activity feature is enabled
10:36:30.386061-0400	Client	[Info] [BraveCore] [features.cc:68] > Frequency capping feature is enabled
10:36:30.390783-0400	Client	[Info] [BraveCore] [ads_impl.cc:364] > Successfully purged orphaned ad events for kInlineContentAd
10:36:30.396765-0400	Client	[Info] [BraveCore] [conversions.cc:216] > Conversion queue is empty
10:36:30.514671-0400	Client	[Info] [BraveCore] [ad_server.cc:85] > Successfully fetched catalog
10:36:30.514786-0400	Client	[Info] [BraveCore] [ad_server.cc:87] > Parsing catalog
10:36:30.519423-0400	Client	[Info] [BraveCore] [bundle.cc:122] > Creative set id d4b0ad8c-b40b-4e5f-8b5d-3fc8fc5891e0 does not support ios
10:36:30.519556-0400	Client	[Info] [BraveCore] [bundle.cc:122] > Creative set id d4b0ad8c-b40b-4e5f-8b5d-3fc8fc5891e0 does not support ios
10:36:30.519648-0400	Client	[Info] [BraveCore] [bundle.cc:122] > Creative set id d4b0ad8c-b40b-4e5f-8b5d-3fc8fc5891e0 does not support ios
10:36:30.519748-0400	Client	[Info] [BraveCore] [bundle.cc:449] > creative set id d4b0ad8c-b40b-4e5f-8b5d-3fc8fc5891e0 has no entries
10:36:30.551704-0400	Client	[Debug] [BraveCore] [bundle.cc:614] > Successfully saved creative inline content ads state
10:36:30.552973-0400	Client	[Debug] [BraveCore] [bundle.cc:642] > Successfully saved creative promoted content ads state
10:36:30.553539-0400	Client	[Info] [BraveCore] [confirmations.cc:61] > SetCatalogIssuers:
10:36:30.553916-0400	Client	[Info] [BraveCore] [confirmations.cc:62] >   Public key: jj+3IDr333J9lzhMe++T2gJQsPHtggCnfgb69T9i4V4=
10:36:30.553986-0400	Client	[Info] [BraveCore] [confirmations.cc:63] >   Issuers:
10:36:30.554083-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.0025BAT
10:36:30.556602-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: +jJE/96GEY+WBLeQVyJgUV2Jn0D7/Dwy+dQfHMwNszU=
10:36:30.556673-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.005BAT
10:36:30.556920-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: QNtxqL+tAbSoISEAr0oSWwzUliccLDv2KoZWXeXeHiU=
10:36:30.557562-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.001BAT
10:36:30.557693-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: wCxc9t+H8Iv9I8e2cKagMK/H8nJf1SKaWdwZR3zg0hU=
10:36:30.557751-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.025BAT
10:36:30.557809-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: yjoFRpnBNgkaS7wf0cgyEFop99q1nuZj/APdxeEVSTc=
10:36:30.557871-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.01BAT
10:36:30.557934-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: oOJO/xLaCXGW6yhpeIfM4K1X2ln7sgdjTCTCHe8BugE=
10:36:30.557988-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.15BAT
10:36:30.558042-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: duj8c6wshE1OsjpkQs2aP4GuFzg6AHRTx0bkdYUKaio=
10:36:30.558099-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.10BAT
10:36:30.558218-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: IDHCAru7GPGQkmBvinkNYOu2HRotn6Zo4Mt92GjQeHc=
10:36:30.558298-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.3BAT
10:36:30.558362-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: cDwS1XxztIX1ywkbYu8aZbIbV7ntR7NQR2dchEJWlnw=
10:36:30.558398-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.05BAT
10:36:30.558499-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: mmXlFlskcF+LjQmJTPQUmoDMV8Co2r+0eNqSyzCywmk=
10:36:30.558655-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0BAT
10:36:30.558717-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: uor3AzFj4OmdCxwetsYD1TxPXZSw40t3j/VOCUyC7Rs=
10:36:30.558770-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.25BAT
10:36:30.558902-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: AkgrYZwV34g8kCp6PMzdpwe7jpHQVTQ9FvBmt77g5gw=
10:36:30.558953-0400	Client	[Info] [BraveCore] [confirmations.cc:66] >     Name: 0.20BAT
10:36:30.559022-0400	Client	[Info] [BraveCore] [confirmations.cc:67] >     Public key: IJYNdVk9MIzc5vgn/4dQ5Xfb55kicxsNy4D4xAAtdX0=
10:36:30.561165-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:49] > Successfully loaded epsilon greedy bandit segments:
10:36:30.561275-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   AC001
10:36:30.561404-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Architecture
10:36:30.561506-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Arts & Entertainment
10:36:30.561620-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Automotive
10:36:30.561674-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   BF001
10:36:30.561748-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Business
10:36:30.562063-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Careers
10:36:30.562113-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Consumer Crypto
10:36:30.562155-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Crypto Curious
10:36:30.562216-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Crypto Purchase Intent
10:36:30.562387-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   DeFi
10:36:30.562482-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Education
10:36:30.562549-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Folklore
10:36:30.562606-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Health & Fitness
10:36:30.562674-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   History
10:36:30.562736-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Hobbies & Interests
10:36:30.562799-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Home
10:36:30.562859-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Law
10:36:30.562902-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Military
10:36:30.562983-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Personal Finance
10:36:30.563045-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Pets
10:36:30.563097-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Philosophy
10:36:30.563157-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Real Estate
10:36:30.563216-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Science
10:36:30.563278-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Sports
10:36:30.563328-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Technology & Computing
10:36:30.563383-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   Travel
10:36:30.563431-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   agriculture
10:36:30.563489-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   cell phones
10:36:30.563524-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   crypto
10:36:30.563594-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   family & parenting
10:36:30.563649-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   fashion
10:36:30.563719-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   food & drink
10:36:30.563754-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   gaming
10:36:30.563816-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   untargeted
10:36:30.563872-0400	Client	[Debug] [BraveCore] [epsilon_greedy_bandit_resource.cc:51] >   weather
10:36:30.565099-0400	Client	[Info] [BraveCore] [ad_server.cc:168] > Fetch catalog in 2 hours, 46 minutes, 19 seconds at 10:52 PM
10:36:30.565301-0400	Client	[Debug] [BraveCore] [bundle.cc:490] > Successfully deleted creative ad notifications state
10:36:30.570935-0400	Client	[Debug] [BraveCore] [bundle.cc:502] > Successfully deleted creative inline content ads state
10:36:30.575690-0400	Client	[Debug] [BraveCore] [bundle.cc:514] > Successfully deleted creative new tab page ads state
10:36:30.577558-0400	Client	[Debug] [BraveCore] [bundle.cc:526] > Successfully deleted creative promoted content ads state
10:36:30.578439-0400	Client	[Debug] [BraveCore] [bundle.cc:538] > Successfully deleted campaigns state
10:36:30.581078-0400	Client	[Debug] [BraveCore] [bundle.cc:550] > Successfully deleted segments state
10:36:30.581459-0400	Client	[Debug] [BraveCore] [bundle.cc:562] > Successfully deleted creative ads state
10:36:30.584310-0400	Client	[Debug] [BraveCore] [bundle.cc:574] > Successfully deleted dayparts state
10:36:30.590348-0400	Client	[Debug] [BraveCore] [bundle.cc:586] > Successfully deleted geo targets state
10:36:30.613475-0400	Client	[Debug] [BraveCore] [bundle.cc:600] > Successfully saved creative ad notifications state
10:36:30.631223-0400	Client	[Debug] [BraveCore] [bundle.cc:628] > Successfully saved creative new tab page ads state
10:36:30.637244-0400	Client	[Debug] [BraveCore] [bundle.cc:654] > Successfully purged expired conversions
10:36:30.643948-0400	Client	[Debug] [BraveCore] [bundle.cc:666] > Successfully saved conversions state
10:36:30.684041-0400	Client	[Info] [BraveCore] [brave_ads.mm:1067] > Downloading bejenkminijgplakmkmcgkhjjnkelbld ads resource version 1
10:36:30.684999-0400	Client	[Info] [BraveCore] [brave_ads.mm:1067] > Downloading mkdhnfmjhklfnamlheoliekgeohamoig ads resource version 1
10:36:30.685801-0400	Client	[Info] [BraveCore] [brave_ads.mm:1067] > Downloading nnqccijfhvzwyrxpxwjrpmynaiazctqb ads resource version 1
10:36:30.693411-0400	Client	[Info] [BraveCore] [brave_ads.mm:1067] > Downloading feibnmjhecfbjpeciancnchbmlobenjn ads resource version 1
10:36:30.765393-0400	Client	[Info] [BraveCore] [brave_ads.mm:1102] > Cached bejenkminijgplakmkmcgkhjjnkelbld ads resource version 1
10:36:30.765460-0400	Client	[Info] [BraveCore] [brave_ads.mm:1110] > bejenkminijgplakmkmcgkhjjnkelbld ads resource updated to version 1
10:36:31.868352-0400	Client	[Info] [BraveCore] [brave_ads.mm:1102] > Cached mkdhnfmjhklfnamlheoliekgeohamoig ads resource version 1
10:36:31.868482-0400	Client	[Info] [BraveCore] [brave_ads.mm:1110] > mkdhnfmjhklfnamlheoliekgeohamoig ads resource updated to version 1
10:36:31.875143-0400	Client	[Info] [BraveCore] [brave_ads.mm:1102] > Cached nnqccijfhvzwyrxpxwjrpmynaiazctqb ads resource version 1
10:36:31.875399-0400	Client	[Info] [BraveCore] [brave_ads.mm:1110] > nnqccijfhvzwyrxpxwjrpmynaiazctqb ads resource updated to version 1
10:36:31.875562-0400	Client	[Info] [BraveCore] [brave_ads.mm:1137] > Loading bejenkminijgplakmkmcgkhjjnkelbld ads resource
10:36:31.875845-0400	Client	[Info] [BraveCore] [brave_ads.mm:1142] > bejenkminijgplakmkmcgkhjjnkelbld ads resource is cached
10:36:31.875941-0400	Client	[Info] [BraveCore] [purchase_intent_resource.cc:44] > Successfully loaded bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
10:36:31.877049-0400	Client	[Info] [BraveCore] [purchase_intent_resource.cc:221] > Parsed purchase intent resource version 1
10:36:31.877587-0400	Client	[Info] [BraveCore] [purchase_intent_resource.cc:56] > Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
10:36:31.877770-0400	Client	[Info] [BraveCore] [brave_ads.mm:1137] > Loading mkdhnfmjhklfnamlheoliekgeohamoig ads resource
10:36:31.878192-0400	Client	[Info] [BraveCore] [brave_ads.mm:1142] > mkdhnfmjhklfnamlheoliekgeohamoig ads resource is cached
10:36:31.878330-0400	Client	[Info] [BraveCore] [anti_targeting_resource.cc:43] > Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
10:36:31.878459-0400	Client	[Info] [BraveCore] [anti_targeting_resource.cc:115] > Parsed anti targeting resource version 1
10:36:31.878621-0400	Client	[Info] [BraveCore] [anti_targeting_resource.cc:53] > Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
10:36:31.878772-0400	Client	[Info] [BraveCore] [brave_ads.mm:1137] > Loading nnqccijfhvzwyrxpxwjrpmynaiazctqb ads resource
10:36:31.879080-0400	Client	[Info] [BraveCore] [brave_ads.mm:1142] > nnqccijfhvzwyrxpxwjrpmynaiazctqb ads resource is cached
10:36:31.879221-0400	Client	[Info] [BraveCore] [conversions_resource.cc:41] > Successfully loaded resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
10:36:31.879421-0400	Client	[Info] [BraveCore] [conversions_resource.cc:123] > Parsed verifiable conversion resource version 1
10:36:31.879604-0400	Client	[Info] [BraveCore] [conversions_resource.cc:51] > Successfully initialized resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
10:36:44.286604-0400	Client	[Info] [BraveCore] [ads_impl.cc:364] > Successfully purged orphaned ad events for kInlineContentAd

  • Verified an inline ad is triggered and shown as the second card in Brave News feed

  • Verified subsequent inline ads are shown when the view port is crossed by more than 50%

  • Verified view ad even is captured in logs

Logs 
[inline_content_ad_event_viewed.cc:25] > Viewed inline content ad with uuid 2fe87417-c383-46b2-8517-789a0daa6256 and creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f
10:42:16.372366-0400	Client	[Info] [BraveCore] [confirmations.cc:90] > Confirming view ad for creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f
10:42:16.372478-0400	Client	[Info] [BraveCore] [redeem_unblinded_token.cc:50] > Redeem unblinded token
10:42:16.372668-0400	Client	[Info] [BraveCore] [redeem_unblinded_token.cc:64] > CreateConfirmation
10:42:16.372756-0400	Client	[Debug] [BraveCore] [redeem_unblinded_token.cc:65] > POST /v1/confirmation/{confirmation_id}/{credential}
10:42:16.373912-0400	Client	[Debug] [BraveCore] [redeem_unblinded_token.cc:69] > URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/6a8f93c3-77fe-41d4-a798-58d6beb6d7b7
  Content: {"creativeInstanceId":"e837131f-13da-46ae-b8d2-a7f9d00efb2f","payload":{},"type":"view"}
  Content Type: application/json
  Method: POST
10:42:18.134531-0400	Client	[Info] [BraveCore] [redeem_unblinded_token.cc:82] > OnCreateConfirmation
10:42:18.134886-0400	Client	[Info] [BraveCore] [confirmations.cc:234] > Successfully sent confirmation with id 6a8f93c3-77fe-41d4-a798-58d6beb6d7b7, creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f and view
  • Verified opening a new tab and viewing the first inline ad doesn't get redeemed
Logs 
10:57:02.218734-0400	Client	[Info] [BraveCore] [inline_content_ad.cc:81] > Inline content ad: Not allowed as already viewed uuid 2fe87417-c383-46b2-8517-789a0daa6256
10:57:02.219000-0400	Client	[Info] [BraveCore] [ads_impl.cc:828] > Failed to fire inline content ad kViewed event for uuid 2fe87417-c383-46b2-8517-789a0daa6256 and creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f

@srirambv srirambv mentioned this issue Aug 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Ads Epic: Brave News QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.30
Development

Successfully merging a pull request may close this issue.

Fix #3872: Add support for Brave News display ads brave/brave-ios
3 participants
@kylehickinson @iccub @srirambv