Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

IPv6 addresses not identified as valid URLs #3866

Closed
iccub opened this issue Jun 29, 2021 · 2 comments · Fixed by #3934
Closed

IPv6 addresses not identified as valid URLs #3866

iccub opened this issue Jun 29, 2021 · 2 comments · Fixed by #3934
Assignees
@Brandon-T
Labels
bug Epic: Webcompat QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include security
Milestone
1.31

Comments

@iccub
Copy link
Contributor

iccub commented Jun 29, 2021

See upstream ticket

mozilla-mobile/firefox-ios#6015
@iccub iccub modified the milestones: 1.29, 1.30 Jun 29, 2021
@Brandon-T Brandon-T self-assigned this Jul 12, 2021
@Brandon-T Brandon-T mentioned this issue Jul 16, 2021
Merged
7 tasks
@soner-yuksel soner-yuksel mentioned this issue Jul 27, 2021
Merged
7 tasks
@soner-yuksel soner-yuksel reopened this Jul 28, 2021
@iccub iccub modified the milestones: 1.30, 1.31 Aug 5, 2021
Brandon-T added a commit that referenced this issue Aug 18, 2021
@Brandon-T
Fix #3866 - Added IPv6 support to the URL bar (#3934)
1745bb0 
* Added IPAddress validation and allow typing in VALID IPv6 addresses into the URL bar.

* Fixed URL parsing to match Desktop and RFC's.

* Small refactor.

* Fixed unit tests
@kjozwiak
Copy link
Member

kjozwiak commented Sep 14, 2021 •
edited
Loading

Verification PASSED on iPhone 12 running iOS 14.7.1 using 1.31 (21.9.13.20) via the following STR/Cases:

IPv6 Supported Google (IPv6) FB (IPv6)
DCD73255-9637-4ACB-B2F5-262B62D3D6BC 8117E120-769B-42E4-A738-FA969B2A9E26 7FAD302A-8C5E-4F38-9805-7FF22DA31417

Verification PASSED on iPad Air (3rd Gen) running iOS 14.7.1 using 1.31 (21.9.13.20) via the following STR/Cases:

IPv6 Supported Google (IPv6) FB (IPv6)
IMG_0302 IMG_0299 IMG_0300

Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.31 (21.9.8.16) via the following STR/Cases:

IPv6 Supported Google (IPv6) FB (IPv6)
IMG_0597 IMG_0595 IMG_0596

Verification PASSED on iPhone 6s+ running iOS 13.6 using 1.31 (21.9.13.20) via the following STR/Cases:

IPv6 Supported Google (IPv6) FB (IPv6)
IMG_0190 IMG_0188 IMG_0189

@Brandon-T
Copy link
Collaborator

https://[2a04:4e42:600::288] won't work because the IP Address doesn't resolve. The browser will attempt to go to that website and timeout eventually. That is the IPv6 of brave.com.

Other websites configured correctly will work though :)

@srirambv srirambv mentioned this issue Sep 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: Webcompat QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include security
Projects
None yet
Milestone
1.31
Development

Successfully merging a pull request may close this issue.

Fix #3866 - Added IPv6 support to the URL bar brave/brave-ios
4 participants
@Brandon-T @kjozwiak @soner-yuksel @iccub