Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Truncate long search query to show which search engine is used #3815

Closed
srirambv opened this issue Jun 18, 2021 · 1 comment · Fixed by #3823
Closed

Truncate long search query to show which search engine is used #3815

srirambv opened this issue Jun 18, 2021 · 1 comment · Fixed by #3823

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 18, 2021

Description:

Truncate long search query to show which search engine is used

Steps to Reproduce

  1. Enable recent searches
  2. Do a long query search on a search engine from quick search bar
  3. Open a new tab and tap URL bar, search query is truncated but doesn't show which SE is used

Actual result:
First search is on DDG with Google set as default

Expected result:
Truncate the search term to show the SE name or add a SE icon before the search term so its easy to understand

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.27(21.6.17.10)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @jamesmudgett @Brandon-T

Brandon-T added a commit that referenced this issue Jun 18, 2021
* Truncate middle just like safari.

* Truncate search suggestions too.
@iccub iccub added this to the 1.28 milestone Jun 18, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Jul 1, 2021

Verification passed on the following devices running 1.28(21.6.30.8)

iPhone XR (iOS 13.5) iPhone 7+ (iOS 14.5.1) iPad Pro (iOS 14.6)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants