Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Expand menu to full when tapping on Settings. #3779

Closed
jamesmudgett opened this issue Jun 14, 2021 · 1 comment · Fixed by #3847
Closed

Expand menu to full when tapping on Settings. #3779

jamesmudgett opened this issue Jun 14, 2021 · 1 comment · Fixed by #3847
Assignees
@kylehickinson
Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.28

Comments

@jamesmudgett
Copy link
Contributor

jamesmudgett commented Jun 14, 2021 •
edited
Loading

Theres a feeling when tapping on Settings from new menu that the space is cramped. Would be better if we could have it expand the new pan modal to 100%. Swiping back does not need to adjust modal.
@iccub iccub added this to the 1.28 milestone Jun 16, 2021
@iccub iccub modified the milestones: 1.28, 1.29 Jun 23, 2021
kylehickinson added a commit that referenced this issue Jun 24, 2021
@kylehickinson
Fix #3779: Expand menu when tapping on settings, history, etc.
bbc014b
@kylehickinson kylehickinson mentioned this issue Jun 24, 2021
Merged
7 tasks
@kylehickinson kylehickinson modified the milestones: 1.29, 1.28 Jun 24, 2021
kylehickinson added a commit that referenced this issue Jun 24, 2021
@kylehickinson
Fix #3779: Expand menu when tapping on settings, history, etc. (#3847)
a970e62
kylehickinson added a commit that referenced this issue Jun 24, 2021
@kylehickinson
Fix #3779: Expand menu when tapping on settings, history, etc. (#3847)
eca3385
@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2021

Verification passed on iPhone XR with iOS 13.5 running 1.28(21.6.30.8)

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.28(21.6.30.8)

Verification passed on iPad Pro with iOS 14.6 running 1.28(21.6.30.8)

@srirambv srirambv mentioned this issue Jul 12, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.28
Development

Successfully merging a pull request may close this issue.

Fix #3779: Expand menu when tapping on settings, history, etc. brave/brave-ios
4 participants
@jamesmudgett @kylehickinson @iccub @srirambv