Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add Brave Search as an alternative search #3745

Closed
bsclifton opened this issue May 28, 2021 · 4 comments · Fixed by #3535
Closed

Add Brave Search as an alternative search #3745

bsclifton opened this issue May 28, 2021 · 4 comments · Fixed by #3535
Assignees
@iccub
Labels
enhancement Epic: Search feature-request QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.27

Comments

@bsclifton
Copy link
Member

bsclifton commented May 28, 2021 •
edited
Loading

Test plan

(for Desktop/Android, see brave/brave-browser#15663)

Full test plan below by @iccub in #3745 (comment)

Description

We recently announced having a search (https://brave.com/brave-search/) and this issue is intended to capture adding this to the browser as an alternate search. It would be in the Standard Tab and Private Tab sections under Search in settings.

Desktop and Android can make use of a config flag and the variations server to roll this out. I think on iOS we'll have to either have Brave Search or not (ex: if we wanted to add or remove, we'd need a new build).

This will include having Brave Search listed in onboarding. Some notes from the desktop issue:

  • favicon: https://cdn.search.brave.com/serp/favicon.ico
  • search: https://search.brave.com/search?q={searchTerms}&source=ios
  • suggest: https://search.brave.com/api/suggest?q={searchTerms}&rich=false

For the Desktop/Android version of this issue, please see brave/brave-browser#15663
@anthonypkeane anthonypkeane added this to the 1.27 milestone Jun 10, 2021
@iccub iccub self-assigned this Jun 11, 2021
@iccub iccub mentioned this issue Jun 14, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Jun 15, 2021
@iccub
Fix #3641, fix #3745 add Brave Search engine, add BraveSearch default…
5df4eb4 
… SE callbacks. (#3535)
iccub added a commit that referenced this issue Jun 15, 2021
@iccub
Ref #3745: Remove rich param from BraveSearch query suggestion endpoint.
b3761ba
@iccub iccub mentioned this issue Jun 15, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Jun 15, 2021
@iccub
Fix #3641, fix #3745 add Brave Search engine, add BraveSearch default…
14d675d 
… SE callbacks. (#3535)
iccub added a commit that referenced this issue Jun 15, 2021
@iccub
Ref #3745: Remove rich param from BraveSearch query suggestion endpoi…
586ed82 
…nt. (#3784)
iccub added a commit that referenced this issue Jun 15, 2021
@iccub
Ref #3745: Remove rich param from BraveSearch query suggestion endpoi…
9651f35 
…nt. (#3784)
@iccub
Copy link
Contributor

iccub commented Jun 15, 2021

Test plan

Naming

  • While testing other plans, verify that Brave Search is displayed as ‘Brave Search beta’ everywhere in the app. This does not apply to the website itself.

Onboarding

  1. Eligible regions test
  • Set device’s region to Canada or US
  • Fresh install 1.27
  • Verify that on onboarding ‘Brave Search beta’ is present as a second option
  • Set Brave Search as default
  • Go to search settings, verify that Brave Search is set for both private and regular mode.
  1. Non eligible
  • Set device’s region to non CA or US one, Poland for example
  • Fresh install 1.27
  • Verify that ‘Brave Search beta’ is not present in the onboarding screen.
  • Go to search settings, verify that you can choose Brave Search as one of SE options.
  1. App upgrade
  • Install 1.26
  • Open the app, play with it for a minute, choose a SE
  • Upgrade to 1.27
  • Verify that SE you chose in 1.26 is still set
  • Go to search settings, verify that BraveSearch is an option to choose from
  • Choose BraveSearch, verify it’s working

Queries

Default callbacks

DRAFT: WEBSITE SIDE NOT IMPLEMENTED YET

  1. Happy path
  • Fresh install 1.27
  • Do not set BraveSearch as default, use Google
  • Go to search.brave.com
  • Verify that default browser prompt is shown
  • Tap on the ‘set as a default’ button
  • Go to the search settings screen, verify Brave Search is set for regular browsing mode only.
  • Type a query in url bar, verify BraveSearch does the query
  1. Private mode
  • Fresh install 1.27
  • Do not set BraveSearch as default, use Google
  • Open private mode
  • Go to search.brave.com
  • Verify that default browser prompt does NOT show
  1. Per session retries
  • Fresh install 1.27
  • Do not set BraveSearch as default, use Google
  • Go to search.brave.com
  • Verify that default browser prompt is shown, do not tap on the button
  • Reload the page 2 times
  • Verify that default browser prompt is shown
  • Reload the page third time
  • Verify that the default browser does not show anymore
  • Try going to search.brave.com in another tab, verify it still does not show
  • (logic here it should show the prompt max 3 times per session until you kill and reload the app)
  1. Total retries
  • Fresh install 1.27
  • Do not set BraveSearch as default, use Google
  • Go to search.brave.com
  • Verify that default browser prompt is shown, do not tap on the button
  • Reload the page 3 times
  • Kill the app, reopen
  • Repeat steps c)-f) until you see the prompt 10 times total
  • Next time you go to search.brave.com you should not see the prompt, whether it’s new browsing session or not
  1. Brave Search already set via onboarding
  • Set device to CA or US region
  • Fresh install 1.27
  • Set BraveSearch as a default on onboarding screen
  • Go to search.brave.com
  • Verify that the default browser prompt is not shown.
  1. Brave Search already set via SE list
  • Fresh install 1.27
  • Go to search settings, set BraveSearch as a default for regular mode
  • Go to search.brave.com
  • Verify that the default browser prompt is not shown.

@bsclifton bsclifton mentioned this issue Jun 16, 2021
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jun 18, 2021 •
edited
Loading

Verification PASSED on iPhone 11 running iOS 14.6 using 1.27 (21.6.17.10)

STR/Cases used to run through Naming, Onboarding and Query as per #3745 (comment).

Japan Germany Canada & USA SE Settings Quick Search
IMG_3734 IMG_3735 IMG_3736 IMG_3737 IMG_3739

Verification PASSED on iPad Air (3rd Gen) running iOS 14.5 using 1.27 (21.6.17.10)

STR/Cases used to run through Naming, Onboarding and Query as per #3745 (comment).

China Spain Canada & USA SE Settings Quick Search
IMG_0278 IMG_0279 IMG_3736 image IMG_0280

Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.27 (21.6.17.10)

STR/Cases used to run through Naming, Onboarding and Query as per #3745 (comment).

Netherlands Poland Canada & USA SE Settings Quick Search
IMG_0570 IMG_0571 IMG_0573 IMG_0575 IMG_0574

@kjozwiak
Copy link
Member

Waiting on more information re: running through the cases for Default callbacks. @bsclifton asking the search team if there's any way of getting a live test case via staging.

@kjozwiak kjozwiak mentioned this issue Jun 18, 2021
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jun 18, 2021 •
edited
Loading

Quick Note:

For the Default Callback feature, search-dev.brave.com was used rather than search.brave.com.

Verification PASSED on iPhone 11 running iOS 14.6 using 1.27 (21.6.18.13)

Default Clicked Set Default After setting default PB (no modal)
IMG_3740 IMG_3743 IMG_3742 IMG_3744

Verification PASSED on iPad Air (3rd Gen) running iOS 14.5 using 1.27 (21.6.18.13)

Default Clicked Set Default After setting default PB (no modal)
IMG_0282 IMG_0283 IMG_0284 IMG_0285

Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.27 (21.6.18.13)

Default Clicked Set Default After setting default PB (no modal)
IMG_0576 IMG_0577 IMG_0580 IMG_0579

@iccub iccub mentioned this issue Jun 18, 2021
Closed
This was referenced Jun 21, 2021
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement Epic: Search feature-request QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.27
Development

Successfully merging a pull request may close this issue.

Add Brave Search engine, add BraveSearch default SE callbacks. brave/brave-ios
4 participants
@kjozwiak @bsclifton @iccub @anthonypkeane