Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up #3383] History tab doesn't match private tab theme when empty #3719

Closed
srirambv opened this issue May 25, 2021 · 1 comment · Fixed by #3720
Closed

[Follow up #3383] History tab doesn't match private tab theme when empty #3719

srirambv opened this issue May 25, 2021 · 1 comment · Fixed by #3720
Assignees
@kylehickinson
Labels
bug Epic: Private-browsing Epic: UI/Theme QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.26

Comments

@srirambv
Copy link
Contributor

Description:

[Follow up #3383] History tab doesn't match private tab theme when empty

Steps to Reproduce

  1. Install 1.26 build
  2. Switch to private mode
    3.Open hisotry, has white theme
  3. Switch to normal mode
  4. Add some history
  5. Switch back to private mode
  6. History shows correct theme
  7. Delete history one by one until all is cleared, goes back to having white background

Actual result:

Expected result:
Follow theme

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.26

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information
@srirambv srirambv added this to the 1.27 milestone May 25, 2021
@srirambv srirambv mentioned this issue May 25, 2021
Closed
kylehickinson added a commit that referenced this issue May 25, 2021
@kylehickinson
Fix #3719: Use correct dynamic color on history empty state
07f9c90
@kylehickinson kylehickinson mentioned this issue May 25, 2021
Merged
7 tasks
@srirambv srirambv modified the milestones: 1.27, 1.26 May 25, 2021
kylehickinson added a commit that referenced this issue May 25, 2021
@kylehickinson
Fix #3719: Use correct dynamic color on history empty state (#3720)
4ddd4c5
kylehickinson added a commit that referenced this issue May 25, 2021
@kylehickinson
Fix #3719: Use correct dynamic color on history empty state (#3720)
8b1775e
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.26(21.5.25.18)

iPhone XR (iOS 13.5) iPhone 7+ (iOS 14.5.1) iPad Pro (iOS 14.5.1)

@kjozwiak kjozwiak mentioned this issue Jun 2, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Private-browsing Epic: UI/Theme QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.26
Development

Successfully merging a pull request may close this issue.

Fix #3719: Use correct dynamic color on history empty state brave/brave-ios
3 participants
@kylehickinson @soner-yuksel @srirambv