Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Farbling & Fingerprinting protections #3700

Closed
anthonypkeane opened this issue May 19, 2021 · 1 comment · Fixed by #5156
Closed

Farbling & Fingerprinting protections #3700

anthonypkeane opened this issue May 19, 2021 · 1 comment · Fixed by #5156
Assignees
@cuba
Labels
enhancement Epic: Shields QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.38

Comments

@anthonypkeane
Copy link

anthonypkeane commented May 19, 2021 •
edited by cuba
Loading

Description:

Similar to brave/brave-browser#8787 please implement

For a spec, please search for "Farbling on iOS" on GDrive

Test Plan

The following test site has been provided with instructions:
https://dev-pages.brave.software/fingerprinting/farbling.html

Linked to:
#3590
#2823
#762
#746
https://github.com/brave/security/issues/800
@cuba cuba self-assigned this Mar 11, 2022
cuba added a commit that referenced this issue Mar 19, 2022
@cuba
Fix #3700: Inject fake "farbling" protection scripts per domain
e2aed0b 
Add files
cuba added a commit that referenced this issue Mar 19, 2022
@cuba
Fix #3700: Remove old FingerprintProtection.js script
e723882
cuba added a commit that referenced this issue Mar 19, 2022
@cuba
Fix #3700: Use new script reload mechanism for DomainUserScript
661af7e
cuba added a commit that referenced this issue Mar 19, 2022
@cuba
Fix #3700: Fix tests
7118f6e
cuba added a commit that referenced this issue Mar 19, 2022
@cuba
Fix #3700: Add ScriptFactory tests
366908c
cuba added a commit that referenced this issue Mar 19, 2022
@cuba
Fix #3700: Add some AudioBuffer and AnalyserNode farbling to our …
2bd16c2 
…script
cuba added a commit that referenced this issue Mar 21, 2022
@cuba
Fix #3700: Rename DomainScriptType to UserScriptType
7433529
cuba added a commit that referenced this issue Mar 21, 2022
@cuba
Fix #3700: Inject "farbling" protection scripts per domain
48a043d
cuba added a commit that referenced this issue Mar 21, 2022
@cuba
Fix #3700: Inject "farbling" protection scripts per domain
8fc7ecd
cuba added a commit that referenced this issue Mar 22, 2022
@cuba
Fix #3700: Farble window.navigation.plugins
79bb4a9
cuba added a commit that referenced this issue Mar 23, 2022
@cuba
Fix #3700: Farble window.navigation.plugins
578a5fd
cuba added a commit that referenced this issue Mar 23, 2022
@cuba
Fix #3700: Farble window.navigator.plugins
3e7a8bd
cuba added a commit that referenced this issue Mar 24, 2022
@cuba
Fix #3700: Inject "farbling" protection scripts per domain
62105d7
cuba added a commit that referenced this issue Mar 24, 2022
@cuba
Fix #3700: Farble window.navigator.plugins
9168cd2
cuba added a commit that referenced this issue Mar 24, 2022
@cuba
Fix #3700: Farble SpeechSynthesis.getVoice()
3f3a47d
cuba added a commit that referenced this issue Mar 24, 2022
@cuba
Fix #3700: Farble window.speechSynthesis.getVoices()
5a8ae48
@cuba cuba mentioned this issue Mar 24, 2022
Merged
7 tasks
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Pass farbling script arguments as concatenated parameters
6a0521a
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Rename RandomManager to RandomConfiguration
96d8711
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Move ScriptSourceType and UserScriptType to own files
fa8c446
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Minor cleanup of tests
4515c64
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Use JSONEncoder to create farbling data
685f0a6
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Use domainKeyData directly as seed
759e5ff
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Cleanup ARC4RandomNumberGenerator
692f02e
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Minor syntax cleanup
5990aca
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Fix issue with SonarCloud failing FarblingProtection.js
536b3cc
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Updated for review
5131b33
cuba added a commit that referenced this issue Mar 28, 2022
@cuba
Fix #3700: Updated for review
cab815f
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Inject "farbling" protection scripts per domain
9966202
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Farble window.navigator.plugins
3bbeda7
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Farble window.speechSynthesis.getVoices()
8bc7582
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Pass farbling script arguments as concatenated parameters
fce2333
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Rename RandomManager to RandomConfiguration
11f4c85
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Move ScriptSourceType and UserScriptType to own files
087da5e
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Minor cleanup of tests
2fb2dff
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Use JSONEncoder to create farbling data
2a3cec2
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Use domainKeyData directly as seed
8284682
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Cleanup ARC4RandomNumberGenerator
60a102e
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Minor syntax cleanup
bd46d35
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Fix issue with SonarCloud failing FarblingProtection.js
60f191a
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Updated for review
d18e196
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Drop ARC4RandomNumberGenerator in favor of srand48 and…
0891120 
… `drand48`
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Updated for review
3bfaf34
cuba added a commit that referenced this issue Mar 30, 2022
@cuba
Fix #3700: Drop ARC4RandomNumberGenerator in favor of srand48 and…
7d21a50 
… `drand48`
cuba added a commit that referenced this issue Apr 4, 2022
@cuba
Fix #3700: Cleanup FarblingProtection.js according to review
05edfad
cuba added a commit that referenced this issue Apr 6, 2022
@cuba
Fix #3700: Inject "farbling" protection scripts per domain
edd7504
@cuba cuba closed this as completed in #5156 Apr 6, 2022
cuba added a commit that referenced this issue Apr 6, 2022
@cuba
Merge pull request #5156 from brave/js/3700-farbling
d60d387 
#3700 Add farbling
@iccub iccub added this to the 1.38 milestone Apr 6, 2022
@srirambv
Copy link
Contributor

srirambv commented May 4, 2022 •
edited
Loading

Verification passed on iPhone XR with iOS 15.4.1 running 1.38 (22.4.29.16)

  • Verified test plan from #5156
  • Verified values are different for plugins when FP is enabled on both pages
  • Verified values are set to 00000000 on both pages when FP is turned off
https://dev-pages.brave.software/fingerprinting/farbling.html https://dev-pages.bravesoftware.com/fingerprinting/farbling.html
Fingerprint ON ShieldsFingerprint OFF Fingerprint ON Shields/Fingerprint OFF

Verification passed on iPad Pro with iOS 15.5 Beta 3 running 1.38 (22.4.29.16)

  • Verified test plan from #5156
  • Verified values are different for plugins when FP is enabled on both pages
  • Verified values are set to 00000000 on both pages when FP is turned off
https://dev-pages.brave.software/fingerprinting/farbling.html https://dev-pages.bravesoftware.com/fingerprinting/farbling.html
Fingerprint ON Shields/Fingerprint OFF Fingerprint ON Shields/Fingerprint OFF

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.38 (22.4.29.16)

  • Verified test plan from #5156
  • Verified values are different for plugins when FP is enabled on both pages
  • Verified values are set to 00000000 on both pages when FP is turned off
https://dev-pages.brave.software/fingerprinting/farbling.html https://dev-pages.bravesoftware.com/fingerprinting/farbling.html
Fingerprint ON Shields/Fingerprint OFF Fingerprint ON Shields/Fingerprint OFF

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
enhancement Epic: Shields QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.38
Development

Successfully merging a pull request may close this issue.

#3700 Add farbling brave/brave-ios
4 participants
@cuba @iccub @anthonypkeane @srirambv