Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Playlist :: Moving a video forward shouldn’t make the toast appear. #3616

Closed
anthonypkeane opened this issue May 3, 2021 · 1 comment · Fixed by #3621
Closed

Playlist :: Moving a video forward shouldn’t make the toast appear. #3616

anthonypkeane opened this issue May 3, 2021 · 1 comment · Fixed by #3621
Assignees
@Brandon-T
Labels
bug Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.25.1

Comments

@anthonypkeane
Copy link

Description:

Moving a video forward shouldn’t make the toast appear.

File
@Brandon-T Brandon-T mentioned this issue May 4, 2021
Merged
7 tasks
@Brandon-T Brandon-T added this to the 1.25 milestone May 4, 2021
@kylehickinson kylehickinson modified the milestones: 1.25, 1.26 May 4, 2021
@iccub iccub added the bug label May 5, 2021
Brandon-T added a commit that referenced this issue May 5, 2021
@Brandon-T
Fix #3616 - Fixing seeking and long-press conflicting (#3621)
f1745ea 
* Fixing Long-Press on video gesture recognizers in Javascript and iOS side.
iccub pushed a commit that referenced this issue May 21, 2021
@Brandon-T @iccub
Fix #3616 - Fixing seeking and long-press conflicting (#3621)
f588a5d 
* Fixing Long-Press on video gesture recognizers in Javascript and iOS side.
@kylehickinson kylehickinson modified the milestones: 1.26, 1.25.1 May 21, 2021
@iccub iccub mentioned this issue May 21, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.25.1(21.5.21,22)

  • Verified steps from issue description
  • Verified seeking a video to a specific position doesn't bring up the Add to playlist context modal
  • Verified context menu modal for playlist only shows up when long press on the video or on the seek bar
  • Verified on both normal and private tabs

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.25.1(21.5.21,22)

  • Verified steps from issue description
  • Verified seeking a video to a specific position doesn't bring up the Add to playlist context modal
  • Verified context menu modal for playlist only shows up when long press on the video or on the seek bar
  • Verified on both normal and private tabs

Verification passed on iPad Pro with iOS 14.5.1 running 1.25.1(21.5.21,22)

  • Verified steps from issue description
  • Verified seeking a video to a specific position doesn't bring up the Add to playlist context modal
  • Verified context menu modal for playlist only shows up when long press on the video or on the seek bar
  • Verified on both normal and private tabs

@kjozwiak kjozwiak mentioned this issue May 24, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.1
Development

Successfully merging a pull request may close this issue.

Fix #3616 - Fixing seeking and long-press conflicting brave/brave-ios
5 participants
@kylehickinson @Brandon-T @iccub @anthonypkeane @srirambv