Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Remove HTTPS upgrade edu-popup #3556

Closed
iccub opened this issue Apr 21, 2021 · 3 comments · Fixed by #3561
Closed

Remove HTTPS upgrade edu-popup #3556

iccub opened this issue Apr 21, 2021 · 3 comments · Fixed by #3561
Assignees
@soner-yuksel
Labels
enhancement Epic: Security QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include sec-high
Milestone
1.25

Comments

@iccub
Copy link
Contributor

iccub commented Apr 21, 2021

Followup of #3542
@iccub iccub added this to the 1.25 milestone Apr 21, 2021
@iccub iccub mentioned this issue Apr 21, 2021
Closed
@soner-yuksel soner-yuksel mentioned this issue Apr 21, 2021
Merged
7 tasks
@soner-yuksel soner-yuksel self-assigned this Apr 21, 2021
iccub pushed a commit that referenced this issue Apr 21, 2021
@soner-yuksel
Fix #3556: Remove HTTPS upgrade pop up (#3561)
d0f5826
@kjozwiak
Copy link
Member

Adding sec-high as @diracdeltas added it via #3542 (comment).

@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.4.2 running 1.25(21.4.21.15)

Verification passed on iPhone XR with iOS 13.5 running 1.25(21.4.21.15)

Verification passed on iPad Pro with iOS 14.4.2 running 1.25(21.4.21.15)

@kjozwiak
Copy link
Member

Changing from release-notes/exclude to release-notes/include as this was a user facing change and labeled as sec-high so worth mentioning.

@kjozwiak kjozwiak mentioned this issue May 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement Epic: Security QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include sec-high
Projects
None yet
Milestone
1.25
Development

Successfully merging a pull request may close this issue.

Fix #3556- Remove HTTPS Upgrade Educational Pop-Over brave/brave-ios
4 participants
@kjozwiak @soner-yuksel @iccub @srirambv