Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement Search Overlay #3554

Closed
anthonypkeane opened this issue Apr 20, 2021 · 1 comment · Fixed by #3645
Closed

Implement Search Overlay #3554

anthonypkeane opened this issue Apr 20, 2021 · 1 comment · Fixed by #3645
Assignees
@Brandon-T
Labels
feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.27

Comments

@anthonypkeane
Copy link

Description:

Please search GDrive for "Search Overlay"
@Brandon-T Brandon-T mentioned this issue May 7, 2021
Merged
7 tasks
@Brandon-T Brandon-T self-assigned this May 11, 2021
@iccub iccub added this to the 1.27 milestone May 12, 2021
iccub pushed a commit that referenced this issue Jun 9, 2021
@Brandon-T
Fix #3554, fix #3399 - Add new search overlay (#3645)
ed59f5d
This was referenced Jun 9, 2021
Closed
Closed
Closed
@iccub iccub mentioned this issue Jun 11, 2021
Closed
6 tasks
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.27(21.6.18.10)

  • Verified QR code scanner is shown when URL is focused
  • Verified able to scan a QR code and load the page immediately
  • Verified able to scan QR code can be scanned on both normal and private tabs
  • Verified QR code scanned on private tabs do not show up in normal tab recent search history
  • Verified Recent Searches option shows up when URL is focused
  • Verified enabling it shows the 5 most recent searches including QR code scanned URL's
  • Verified show more shows up when there are more than 5 searches and clicking on it shows the whole list
  • Verified clear option for recent search throws confirmation before clearing it
  • Verified disabling recent searches from Search Engine settings doesn't clear the history
  • Verified copying URL/text to clipboard and focusing on URL bar shows Paste & Go button
  • Verified copying URL and selecting Paste & Go loads the page
  • Verified copying text and selecting Paste & Go performs search
  • Verified clicking on the arrow mark in recent searches only fills the URL with search term and doesn't perform/load the search
  • Verified performing a search using Quick SE adds on StartPage text to the search history
  • Screenshots can be found here

Verification passed on iPhone 7+ with iOS 14.6 running 1.27(21.6.18.10)

  • Verified QR code scanner is shown when URL is focused
  • Verified able to scan a QR code and load the page immediately
  • Verified able to scan QR code can be scanned on both normal and private tabs
  • Verified QR code scanned on private tabs do not show up in normal tab recent search history
  • Verified Recent Searches option shows up when URL is focused
  • Verified enabling it shows the 5 most recent searches including QR code scanned URL's
  • Verified show more shows up when there are more than 5 searches and clicking on it shows the whole list
  • Verified clear option for recent search throws confirmation before clearing it
  • Verified disabling recent searches from Search Engine settings doesn't clear the history
  • Verified copying URL/text to clipboard and focusing on URL bar shows Paste & Go button
  • Verified copying URL and selecting Paste & Go loads the page
  • Verified copying text and selecting Paste & Go performs search
  • Verified clicking on the arrow mark in recent searches only fills the URL with search term and doesn't perform/load the search
  • Verified performing a search using Quick SE adds on StartPage text to the search history
  • Screenshots can be found here

Verification passed on iPad Pro with iOS 14.6 running 1.27(21.6.18.10)

  • Verified QR code scanner is shown when URL is focused
  • Verified able to scan a QR code and load the page immediately
  • Verified able to scan QR code can be scanned on both normal and private tabs
  • Verified QR code scanned on private tabs do not show up in normal tab recent search history
  • Verified Recent Searches option shows up when URL is focused
  • Verified enabling it shows the 5 most recent searches including QR code scanned URL's
  • Verified show more shows up when there are more than 5 searches and clicking on it shows the whole list
  • Verified clear option for recent search throws confirmation before clearing it
  • Verified disabling recent searches from Search Engine settings doesn't clear the history
  • Verified copying URL/text to clipboard and focusing on URL bar shows Paste & Go button
  • Verified copying URL and selecting Paste & Go loads the page
  • Verified copying text and selecting Paste & Go performs search
  • Verified clicking on the arrow mark in recent searches only fills the URL with search term and doesn't perform/load the search
  • Verified performing a search using Quick SE adds on StartPage text to the search history
  • Screenshots can be found here

@kjozwiak kjozwiak mentioned this issue Jun 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.27
Development

Successfully merging a pull request may close this issue.

Fix #3554 - Pre-Search Implementation brave/brave-ios
5 participants
@Brandon-T @kjozwiak @iccub @anthonypkeane @srirambv