Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

New Menu UI #3491

Closed
kylehickinson opened this issue Mar 30, 2021 · 1 comment · Fixed by #3465
Closed

New Menu UI #3491

kylehickinson opened this issue Mar 30, 2021 · 1 comment · Fixed by #3465
Assignees
@kylehickinson
Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.26

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Mar 30, 2021 •
edited
Loading

Change the ••• menu to display a scrollable modal which will allow for more dynamic actions within the menu.

Main differences:

  • Starts half expanded, can be scrolled to full expansion
  • Most screens are presented within the menu (with the exception of Playlist for the time being) and website actions
  • Website actions are brought up to the main menu rather than living only within the Share With… menu

Expected behaviour of all actions within the new menu should match previous behaviour of old menu (Bookmarks bring up bookmarks, downloads brings up downloads, show desktop site loads desktop sites, etc. etc.)
@kylehickinson kylehickinson added this to the 1.25 milestone Mar 30, 2021
@kylehickinson kylehickinson self-assigned this Mar 30, 2021
@kylehickinson kylehickinson mentioned this issue Mar 30, 2021
Merged
7 tasks
@iccub iccub modified the milestones: 1.25, 1.26 Apr 7, 2021
kylehickinson added a commit that referenced this issue May 6, 2021
@kylehickinson
Fix #3491: Add New Menu UI (#3465)
22a4b0b
kylehickinson added a commit that referenced this issue May 11, 2021
@kylehickinson
Ref #3491: Move share with button; Fix bookmarks dismiss on navigation
c2613f6
@kylehickinson kylehickinson mentioned this issue May 11, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue May 12, 2021
@kylehickinson
Ref #3491: Move share with button; Fix bookmarks dismiss on navigation (
bafb657 
#3672)
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.26(25.1.25.18)

Verified test plan from #3465
  • Verified all menu options work as expected
  • Verified both light/dark theme work fine on menu
  • Verified VPN button works correctly and shows loading indicator when trying to connect
New Tab Page Website Website Expanded VPN connecting
image image image image

Verification passed on iPhone XR with iOS 14.5.1 running 1.26(25.1.26.21)

Verified test plan from #3465
  • Verified all menu options work as expected
  • Verified both light/dark theme work fine on menu
  • Verified VPN button works correctly and shows loading indicator when trying to connect
New Tab Page Website Website Expanded VPN connecting
image image image image

Verification passed on iPad Pro with iOS 14.5.1 running 1.26(25.1.26.21)

Verified test plan from #3465
  • Verified all menu options work as expected
  • Verified both light/dark theme work fine on menu
  • Verified VPN button works correctly and shows loading indicator when trying to connect
New Tab Page Website VPN connecting
image image image

@kjozwiak kjozwiak mentioned this issue Jun 2, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.26
Development

Successfully merging a pull request may close this issue.

Fix #3491: Add New Menu UI brave/brave-ios
3 participants
@kylehickinson @iccub @srirambv