Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update themes to match Brave colour palettes #3482

Closed
kylehickinson opened this issue Mar 29, 2021 · 5 comments · Fixed by #3505
Closed

Update themes to match Brave colour palettes #3482

kylehickinson opened this issue Mar 29, 2021 · 5 comments · Fixed by #3505

Comments

@kylehickinson
Copy link
Collaborator

The light and dark theme both need updating to match Brave's colour palettes. These more closely resemble the colours used in the Shields/Rewards popovers

@jamesmudgett jamesmudgett self-assigned this Mar 29, 2021
jamesmudgett added a commit that referenced this issue Apr 5, 2021
…pdated but not 1:1 Brave colors as we are missing needed variety). Also, updated the rewards panel icon window-sad, to window-happy.
@iccub iccub added this to the 1.25 milestone Apr 6, 2021
jamesmudgett added a commit that referenced this issue Apr 6, 2021
…pdated but not 1:1 Brave colors as we are missing needed variety). Also, updated the rewards panel icon window-sad, to window-happy.
jamesmudgett added a commit that referenced this issue Apr 6, 2021
…pdated but not 1:1 Brave colors as we are missing needed variety). Also, updated the rewards panel icon window-sad, to window-happy.
jamesmudgett added a commit that referenced this issue Apr 6, 2021
fix #3482, fix #2558 - update themes to use latest Brave colors (except light: u…
@srirambv
Copy link
Contributor

srirambv commented Apr 26, 2021

Marking as QA Blocked on test plan. @jamesmudgett please add a test plan/screenshots for reference so QA can verify the issue.

@jamesmudgett
Copy link
Contributor

jamesmudgett commented Apr 29, 2021

712AF2DB-4AFC-4C0C-939D-4436F9C1E44B 2EB0AC68-46B1-4EC2-AEC9-3C05BD6CD25E 325E26E4-DA6C-48AA-A01F-2F6AE53FC291 8D6EB7DA-3E6F-4AA3-8625-89937359D6C7 25B5C9D3-F519-452E-8245-B02D33D2CD1C
A79406AC-12B9-4290-9BC6-EB536EA38527 FAA53930-F1CD-4612-8533-CF82CC04BA3F 7AEBCF56-BD03-4F30-B84D-08805884B376 26A57172-03C4-4B3F-8BE4-FBF8FD244A34 07C47CAE-0E76-407F-8882-2040A85523ED

@jamesmudgett
Copy link
Contributor

07C47CAE-0E76-407F-8882-2040A85523ED

@jamesmudgett
Copy link
Contributor

The shots added above are from expected UI color changes.

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.25(21.4.28.19)

Verified against screenshots from #3482 (comment)
image image image image image
image image image image image

Verification passed on iPhone 7+ with iOS 14.5 running 1.25(21.4.28.19)

Verified against screenshots from #3482 (comment)
image image image image image
image image image image image

Verification passed on iPad Pro with iOS 14.4.2 running 1.25(21.4.28.19)

Verified against screenshots from #3482 (comment)
image image image image image
image image image image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.